-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix lxml import in show_versions #23949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @nixphix! Thanks for submitting the PR.
|
can you add a test for this? somethign like
would be enough |
Codecov Report
@@ Coverage Diff @@
## master #23949 +/- ##
==========================================
+ Coverage 92.31% 92.31% +<.01%
==========================================
Files 161 161
Lines 51473 51513 +40
==========================================
+ Hits 47517 47554 +37
- Misses 3956 3959 +3
Continue to review full report at Codecov.
|
@jreback Added test case |
hmm then why didn’t our build fail? |
Possibly we didn't have an environment with lxml but not openpyxl.
…On Wed, Nov 28, 2018 at 12:14 PM Jeff Reback ***@***.***> wrote:
hmm then why didn’t our build fail?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23949 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIrsdFKOtG5nQjQvMduBoAw_wJfTEks5uztJqgaJpZM4Y2AZF>
.
|
Thanks @nixphix! |
* BUG: Fix lxml import in show_versions Fixes pandas-dev#23934
* BUG: Fix lxml import in show_versions Fixes pandas-dev#23934
Fixed lxml import issue
git diff upstream/master -u -- "*.py" | flake8 --diff