Skip to content

BUG: Fix lxml import in show_versions #23949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2018
Merged

BUG: Fix lxml import in show_versions #23949

merged 4 commits into from
Nov 29, 2018

Conversation

nixphix
Copy link
Contributor

@nixphix nixphix commented Nov 27, 2018

Fixed lxml import issue

@pep8speaks
Copy link

Hello @nixphix! Thanks for submitting the PR.

@jreback
Copy link
Contributor

jreback commented Nov 27, 2018

can you add a test for this?

somethign like

subprocess.check_call([sys.executable, "-c", "import pandas; pandas.show_versions()"])

would be enough

@jreback jreback added the Build Library building on various platforms label Nov 27, 2018
@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #23949 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23949      +/-   ##
==========================================
+ Coverage   92.31%   92.31%   +<.01%     
==========================================
  Files         161      161              
  Lines       51473    51513      +40     
==========================================
+ Hits        47517    47554      +37     
- Misses       3956     3959       +3
Flag Coverage Δ
#multiple 90.71% <ø> (ø) ⬆️
#single 42.42% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/util/_print_versions.py 15.71% <ø> (ø) ⬆️
pandas/core/arrays/timedeltas.py 96.25% <0%> (-0.19%) ⬇️
pandas/tseries/offsets.py 96.84% <0%> (-0.14%) ⬇️
pandas/core/groupby/ops.py 96.75% <0%> (-0.05%) ⬇️
pandas/core/indexes/interval.py 94.69% <0%> (ø) ⬆️
pandas/core/indexes/multi.py 95.49% <0%> (ø) ⬆️
pandas/core/frame.py 97.02% <0%> (ø) ⬆️
pandas/core/generic.py 96.84% <0%> (ø) ⬆️
pandas/core/indexes/period.py 93.07% <0%> (ø) ⬆️
pandas/core/indexes/base.py 96.48% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2712c8f...0f9bae9. Read the comment docs.

@nixphix
Copy link
Contributor Author

nixphix commented Nov 28, 2018

@jreback Added test case

@jreback jreback added this to the 0.24.0 milestone Nov 28, 2018
@jreback
Copy link
Contributor

jreback commented Nov 28, 2018

hmm then why didn’t our build fail?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Nov 28, 2018 via email

@TomAugspurger TomAugspurger merged commit d9a037e into pandas-dev:master Nov 29, 2018
@TomAugspurger
Copy link
Contributor

Thanks @nixphix!

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show_versions fails on master with latest lxml
4 participants