-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix PEP-8 issues in 10min.rst #23908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Fabian Haase <[email protected]>
doc/source/10min.rst
Outdated
import pandas as pd | ||
|
||
.. ipython:: python | ||
:suppress: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not at the beginning and with numpy and pandas imports in the same suppress block? I think this is what we do in all the other pages, right?
Signed-off-by: Fabian Haase <[email protected]>
@savefig frame_plot_basic.png | ||
plt.figure(); df.plot(); plt.legend(loc='best') | ||
plt.legend(loc='best') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've been ending those with semicolon in other parts, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's basically mixed sometimes with sometimes without.
I'd prefer to put ;
at the end to suppress the output, but you've asked to PR that in seperate PR's and fixing PEP-8 issues is to have no ;
at the end of a line.
I'm waiting for #23847 in order to ignore E703
on a file-based basis.
Codecov Report
@@ Coverage Diff @@
## master #23908 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 161 161
Lines 51498 51498
=======================================
Hits 47530 47530
Misses 3968 3968
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let's merge this then, we can add semicolons to hide the plots output in a separate PR (we can open an issue to discuss, in case someone prefers not to ignore the flake8 rule
thanks @FHaase |
No description provided.