Skip to content

DOC: Fix PEP-8 issues in 10min.rst #23908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Conversation

FHaase
Copy link
Contributor

@FHaase FHaase commented Nov 25, 2018

No description provided.

Signed-off-by: Fabian Haase <[email protected]>
import pandas as pd

.. ipython:: python
:suppress:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not at the beginning and with numpy and pandas imports in the same suppress block? I think this is what we do in all the other pages, right?

@datapythonista datapythonista added Docs Code Style Code style, linting, code_checks labels Nov 25, 2018
Signed-off-by: Fabian Haase <[email protected]>
@savefig frame_plot_basic.png
plt.figure(); df.plot(); plt.legend(loc='best')
plt.legend(loc='best')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've been ending those with semicolon in other parts, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's basically mixed sometimes with sometimes without.
I'd prefer to put ; at the end to suppress the output, but you've asked to PR that in seperate PR's and fixing PEP-8 issues is to have no ; at the end of a line.

I'm waiting for #23847 in order to ignore E703 on a file-based basis.

@codecov
Copy link

codecov bot commented Nov 25, 2018

Codecov Report

Merging #23908 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23908   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         161      161           
  Lines       51498    51498           
=======================================
  Hits        47530    47530           
  Misses       3968     3968
Flag Coverage Δ
#multiple 90.69% <ø> (ø) ⬆️
#single 42.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7b187a...ece28ac. Read the comment docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's merge this then, we can add semicolons to hide the plots output in a separate PR (we can open an issue to discuss, in case someone prefers not to ignore the flake8 rule

@jreback jreback added this to the 0.24.0 milestone Nov 27, 2018
@jreback jreback merged commit 90961f2 into pandas-dev:master Nov 27, 2018
@jreback
Copy link
Contributor

jreback commented Nov 27, 2018

thanks @FHaase

@FHaase FHaase deleted the fix-pep8-10min branch December 17, 2018 13:51
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants