Skip to content

TST: Fix integer ops comparison test #23619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pandas/tests/arrays/test_integer.py
Original file line number Diff line number Diff line change
Expand Up @@ -314,11 +314,11 @@ def test_rpow_one_to_na(self):

class TestComparisonOps(BaseOpsUtil):

def _compare_other(self, s, data, op_name, other):
def _compare_other(self, data, op_name, other):
op = self.get_op_from_name(op_name)

# array
result = op(s, other)
result = pd.Series(op(data, other))
expected = pd.Series(op(data._data, other))

# fill the nan locations
Expand All @@ -340,14 +340,12 @@ def _compare_other(self, s, data, op_name, other):

def test_compare_scalar(self, data, all_compare_operators):
op_name = all_compare_operators
s = pd.Series(data)
self._compare_other(s, data, op_name, 0)
self._compare_other(data, op_name, 0)

def test_compare_array(self, data, all_compare_operators):
op_name = all_compare_operators
s = pd.Series(data)
other = pd.Series([0] * len(data))
self._compare_other(s, data, op_name, other)
self._compare_other(data, op_name, other)


class TestCasting(object):
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ known_post_core=pandas.tseries,pandas.io,pandas.plotting
sections=FUTURE,STDLIB,THIRDPARTY,PRE_CORE,DTYPES,FIRSTPARTY,POST_CORE,LOCALFOLDER

known_first_party=pandas
known_third_party=Cython,numpy,python-dateutil,pytz,pyarrow
known_third_party=Cython,numpy,python-dateutil,pytz,pyarrow,pytest
multi_line_output=4
force_grid_wrap=0
combine_as_imports=True
Expand Down