Skip to content

STYLE: Run Isort on tests-> util, series, arrays #23501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

thoo
Copy link
Contributor

@thoo thoo commented Nov 4, 2018

  • partial Fix import formatting using isort #23334
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
    Run isort on some leftover files from tests/util, tests/arrays and tests/series.

@pep8speaks
Copy link

Hello @thoo! Thanks for submitting the PR.

@datapythonista datapythonista changed the title Run Isort on tests-> util,sereis,arrays STYLE: Run Isort on tests-> util, series, arrays Nov 5, 2018
@datapythonista datapythonista added the Code Style Code style, linting, code_checks label Nov 5, 2018
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks @thoo

@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #23501 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23501   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         161      161           
  Lines       51197    51197           
=======================================
  Hits        47220    47220           
  Misses       3977     3977
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 42.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ab22f...295febf. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Nov 5, 2018
@jreback jreback merged commit 391aded into pandas-dev:master Nov 5, 2018
@jreback
Copy link
Contributor

jreback commented Nov 5, 2018

thanks!

thoo added a commit to thoo/pandas that referenced this pull request Nov 5, 2018
…fixed

* upstream/master:
  Run Isort on tests-> util,sereis,arrays (pandas-dev#23501)
  DOC: Fix syntax error in groupby docs (pandas-dev#23498)
  DOC: Fix DataFrame.nlargest and DataFrame.nsmallest doctests (pandas-dev#23202)
  DOC: Remove dead link and update links to https (pandas-dev#23476)
@alimcmaster1
Copy link
Member

thanks! @thoo

JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@thoo thoo deleted the run_isort_on_leftover_files branch January 2, 2019 20:26
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants