-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix syntax error in groupby docs #23498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix syntax error in groupby docs #23498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe make this actually do something? e.g .sum() to show the resulting frame
@jreback : That's fair. I do want to make sure that the Travis build first doesn't timeout. Then we can add something to show the result. |
Codecov Report
@@ Coverage Diff @@
## master #23498 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 161 161
Lines 51197 51197
=======================================
Hits 47220 47220
Misses 3977 3977
Continue to review full report at Codecov.
|
Follow-up to pandas-devgh-23394.
2b8d556
to
5248094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jreback : Made the suggested change, and all builds (including the doc build) are green. PTAL. |
@gfyoung Thanks for finding the trigger for the doc time out! Luckily it was something very simple in the end ;) (I still don't understand how this caused such a slow down without giving actual errors) (but maybe in the future if you are re-doing a PR that broke the doc build, make sure to check if now the doc build is actually working .. :)) |
@jorisvandenbossche : The doc builds were working in fact when I first opened the PR. It was a mysterious bug that reared its head in strange ways. 🙂 |
@gfyoung yeah, I can only see the status of the last commit (in general, can you start adding new commits instead of rebasing/amending a single commit in a PR ?), and there it was actually failing, although it looks green. I think we discussed that before, but we should probably move the doc build out of "allowed failures". |
…fixed * upstream/master: Run Isort on tests-> util,sereis,arrays (pandas-dev#23501) DOC: Fix syntax error in groupby docs (pandas-dev#23498) DOC: Fix DataFrame.nlargest and DataFrame.nsmallest doctests (pandas-dev#23202) DOC: Remove dead link and update links to https (pandas-dev#23476)
https://travis-ci.org/pandas-dev/pandas/jobs/450582832
#15559 has been rearing its head again. Turns out the reason for the timeout is one silly, missing parenthesis in the
groupby.rst
docs (that was the cause as well in #15506). 😆Follow-up to #23394.