-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: stricter monotonicity/uniqueness tests (part 2) #23294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: stricter monotonicity/uniqueness tests (part 2) #23294
Conversation
Hello @topper-123! Thanks for submitting the PR.
|
Looks like some related test failures though. |
f821f86
to
8a86d7d
Compare
8a86d7d
to
92bbf56
Compare
Codecov Report
@@ Coverage Diff @@
## master #23294 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 169 169
Lines 50897 50897
=======================================
Hits 46940 46940
Misses 3957 3957
Continue to review full report at Codecov.
|
The failure issue was that As this PR mainly concerns itself with |
thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff
Continuation of #23256.
By making the uniqueness tests stricter (i.e. testing for actual True/False rather than truthy/Falsy values) I think we get better ensurance that some PR doesn't accidentally turn a property into a method or that the property doesn't accidentally returns a non-boolean return value.