DOC: Added a Multi Index example for the Series.sum method #23279

vadakattu · 2018-10-22T17:38:40Z

Added a simple example of using the sum method on a multi-indexed series.

passes git diff upstream/master -u -- "*.py" | flake8 --diff

pep8speaks · 2018-10-22T19:52:39Z

Hello @vadakattu! Thanks for submitting the PR.

There are no PEP8 issues in the file pandas/core/generic.py !

jreback · 2018-10-23T02:25:52Z

cc @datapythonista

codecov · 2018-10-23T16:57:35Z

Codecov Report

Merging #23279 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23279   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         169      169           
  Lines       50924    50924           
=======================================
  Hits        46968    46968           
  Misses       3956     3956

Flag	Coverage Δ
#multiple	`90.65% <ø> (ø)`	⬆️
#single	`42.28% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/core/generic.py	`96.79% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2d501...d3e07bf. Read the comment docs.

datapythonista

lgtm

I'm on my phone and can't check whether travis failure is caused by the changes, but happy to merge this on green

vadakattu · 2018-10-24T14:07:02Z

Travis failure seems to be a code coverage timeout while uploading the second report, /tmp/cov-multiple.xml. Should I submit an empty commit to rerun the test suite?

    project root: .
    Fixing merge commit SHA
    Yaml found at: codecov.yml
    -> Found 1 reports
==> Detecting git/mercurial file structure
==> Appending build variables
    + TRAVIS_OS_NAME
    + TRAVIS_PYTHON_VERSION
==> Reading reports
    + /tmp/cov-multiple.xml bytes=2000278
==> Appending adjustments
    http://docs.codecov.io/docs/fixing-reports
    + Found adjustments
==> Gzipping contents
==> Uploading reports
    url: https://codecov.io
    query: branch=master&commit=649fd4c37bee8af43ff6ae0eec78f1a524a49f7b&build=45600.4&build_url=&name=&tag=&slug=pandas-dev%2Fpandas&service=travis&flags=multiple&pr=23279&job=445227336
    -> Pinging Codecov
    -> Uploading
    X> Failed to upload
    -> Sleeping for 30s and trying again...
    -> Pinging Codecov
    -> Uploading
    X> Failed to upload
    -> Sleeping for 30s and trying again...
The job exceeded the maximum time limit for jobs, and has been terminated.

datapythonista · 2018-10-24T14:09:23Z

you can merge master into your branch and push, that's what we usually do (equivalent to an empty commit)

datapythonista · 2018-10-25T14:15:13Z

I think it's worth using from_product in the example:
https://pandas.pydata.org/pandas-docs/stable/generated/pandas.MultiIndex.from_product.html

vadakattu · 2018-10-25T14:29:51Z

I think it's worth using from_product in the example:
https://pandas.pydata.org/pandas-docs/stable/generated/pandas.MultiIndex.from_product.html

Oh nice! Didn't know about that, will update.

datapythonista

not sure if the indentation of the index is correct, if you can make sure that it follows pep8, this looks good to me

vadakattu · 2018-10-25T15:45:35Z

It seemed ok with git diff upstream/master -u -- "*.py" | flake8 --diff but I've reformatted nonetheless -- is this indentation better?

datapythonista

lgtm, thanks!

WillAyd · 2018-10-25T23:37:42Z

Thanks @vadakattu

…ndas * repo_org/master: (23 commits) DOC: Add docstring validations for "See Also" section (pandas-dev#23143) TST: Fix test assertion (pandas-dev#23357) BUG: Handle Period in combine (pandas-dev#23350) REF: SparseArray imports (pandas-dev#23329) CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992) DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051) Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341) TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304) API: Add sparse Acessor (pandas-dev#23183) PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235) fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302) BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317) TST: re-enable gbq tests (pandas-dev#23303) Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311) isort imports-io (pandas-dev#23332) DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279) REF: Make PeriodArray an ExtensionArray (pandas-dev#22862) DOC: Added Examples for Series max (pandas-dev#23298) API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644) BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291) ...

…xamples * repo_org/master: (83 commits) DOC: Add docstring validations for "See Also" section (pandas-dev#23143) TST: Fix test assertion (pandas-dev#23357) BUG: Handle Period in combine (pandas-dev#23350) REF: SparseArray imports (pandas-dev#23329) CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992) DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051) Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341) TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304) API: Add sparse Acessor (pandas-dev#23183) PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235) fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302) BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317) TST: re-enable gbq tests (pandas-dev#23303) Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311) isort imports-io (pandas-dev#23332) DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279) REF: Make PeriodArray an ExtensionArray (pandas-dev#22862) DOC: Added Examples for Series max (pandas-dev#23298) API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644) BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291) ...

…v#23279)

Krishna added 3 commits October 22, 2018 18:04

Added a Multi Index example for the Series.sum method

d71a944

Added description before method call.

89c2977

Added line break for formatting.

91fad75

jreback added the Docs label Oct 23, 2018

Krishna added 2 commits October 23, 2018 16:22

DOC: corrected output.

3a5f9fe

Merge branch 'master' of github.com:pandas-dev/pandas into series-sum

649fd4c

datapythonista approved these changes Oct 24, 2018

View reviewed changes

Krishna added 4 commits October 24, 2018 16:39

Merge branch 'master' of github.com:pandas-dev/pandas into series-sum

581518e

Merge branch 'master' of github.com:pandas-dev/pandas into series-sum

9c10458

Merge branch 'master' of github.com:pandas-dev/pandas into series-sum

1a1298f

DOC: Restructured indexing as requested.

56c0340

DOC: Switched from MultiIndex.from_arrays to MultiIndex.from_product

920526b

datapythonista reviewed Oct 25, 2018

View reviewed changes

vadakattu mentioned this pull request Oct 25, 2018

DOC: Added Examples for Series max #23298

Merged

2 tasks

DOC: Reformatting indents

d3e07bf

datapythonista approved these changes Oct 25, 2018

View reviewed changes

WillAyd approved these changes Oct 25, 2018

View reviewed changes

WillAyd merged commit 8da1b36 into pandas-dev:master Oct 25, 2018

vadakattu deleted the series-sum branch October 26, 2018 09:47

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018

DOC: Added a Multi Index example for the Series.sum method (pandas-de…

8f3066e

…v#23279)

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

DOC: Added a Multi Index example for the Series.sum method (pandas-de…

7d4dde2

…v#23279)

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

DOC: Added a Multi Index example for the Series.sum method (pandas-de…

a42a769

…v#23279)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DOC: Added a Multi Index example for the Series.sum method #23279

DOC: Added a Multi Index example for the Series.sum method #23279

vadakattu commented Oct 22, 2018 •

edited

Loading

pep8speaks commented Oct 22, 2018

jreback commented Oct 23, 2018

codecov bot commented Oct 23, 2018 •

edited

Loading

datapythonista left a comment

vadakattu commented Oct 24, 2018

datapythonista commented Oct 24, 2018

datapythonista commented Oct 25, 2018

vadakattu commented Oct 25, 2018

datapythonista left a comment

vadakattu commented Oct 25, 2018

datapythonista left a comment

WillAyd commented Oct 25, 2018

DOC: Added a Multi Index example for the Series.sum method #23279

DOC: Added a Multi Index example for the Series.sum method #23279

Conversation

vadakattu commented Oct 22, 2018 • edited Loading

pep8speaks commented Oct 22, 2018

jreback commented Oct 23, 2018

codecov bot commented Oct 23, 2018 • edited Loading

Codecov Report

datapythonista left a comment

Choose a reason for hiding this comment

vadakattu commented Oct 24, 2018

datapythonista commented Oct 24, 2018

datapythonista commented Oct 25, 2018

vadakattu commented Oct 25, 2018

datapythonista left a comment

Choose a reason for hiding this comment

vadakattu commented Oct 25, 2018

datapythonista left a comment

Choose a reason for hiding this comment

WillAyd commented Oct 25, 2018

vadakattu commented Oct 22, 2018 •

edited

Loading

codecov bot commented Oct 23, 2018 •

edited

Loading