Skip to content

DOC: update the pandas.DateTimeArrayMixin.is_month_start docstring #23051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CalmDownKarm
Copy link
Contributor

@CalmDownKarm CalmDownKarm commented Oct 9, 2018

@pep8speaks
Copy link

pep8speaks commented Oct 9, 2018

Hello @CalmDownKarm! Thanks for updating the PR.

Comment last updated on October 11, 2018 at 07:18 Hours UTC

@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #23051 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23051      +/-   ##
==========================================
+ Coverage   92.19%   92.22%   +0.03%     
==========================================
  Files         169      169              
  Lines       50954    51259     +305     
==========================================
+ Hits        46975    47275     +300     
- Misses       3979     3984       +5
Flag Coverage Δ
#multiple 90.66% <100%> (+0.05%) ⬆️
#single 42.23% <100%> (-0.04%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/datetimes.py 97.46% <100%> (+0.08%) ⬆️
pandas/io/feather_format.py 77.14% <0%> (-8.58%) ⬇️
pandas/core/arrays/datetimelike.py 93.21% <0%> (-1.69%) ⬇️
pandas/core/dtypes/concat.py 96.34% <0%> (-1.35%) ⬇️
pandas/core/indexes/period.py 92.27% <0%> (-0.98%) ⬇️
pandas/core/arrays/sparse.py 91.84% <0%> (-0.71%) ⬇️
pandas/core/arrays/categorical.py 95.21% <0%> (-0.41%) ⬇️
pandas/core/ops.py 94.24% <0%> (-0.4%) ⬇️
pandas/io/common.py 70.76% <0%> (-0.28%) ⬇️
pandas/core/dtypes/common.py 94.86% <0%> (-0.25%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9285820...9e0f242. Read the comment docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few formatting problems. There are two things you should do:

  • Validate the docstring for formatting errors: ./scripts/validate_docstrings.py pandas.DateTimeArrayMixin.is_month_start
  • Generate the html and see if it renders correctly: ./doc/make.py html --single=pandas.DateTimeArrayMixin.is_month_start

@CalmDownKarm
Copy link
Contributor Author

@datapythonista I made the changes you asked for, but both commands you asked me to run failed - AttributeError: module 'pandas' has no attribute 'DateTimeArrayMixin' probably a broken setup on my end?

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command to run is ./scripts/validate_docstrings.py pandas.core.arrays.datetimes.DateTimeArrayMising.

Got the full path to the class from the PR title, but seems like it's been shortened there.

@datapythonista
Copy link
Member

is the validation script happy now?

@datapythonista
Copy link
Member

seems like there are whitespaces at the end of some lines in your code (check travis), can you remove them and validate pep8

@CalmDownKarm
Copy link
Contributor Author

@datapythonista fixed flake8 and validation script works now, but I'm unable to generate the html.

python scripts/validate_docstrings.py pandas.core.arrays.datetimes.DatetimeArrayMixin.is_month_start
validates fine
but if I run
python doc/make.py html --single=pandas.core.arrays.datetimes.DatetimeArrayMixin.is_month_start
I get
AttributeError: module 'pandas.core.arrays' has no attribute 'datetimes'

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I didn't realize before, but probably it makes sense to have a common template for is_month_start and is_month_end, but we can take care of that in a separate PR.

@jbrockmendel do you want to take a look and merge if you're happy

karmanya.aggarwal added 2 commits October 18, 2018 04:09
Merge branch 'master' of github.com:pandas-dev/pandas into datetimes_docstring
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jreback jreback added this to the 0.24.0 milestone Oct 26, 2018
@jorisvandenbossche jorisvandenbossche merged commit cd16b91 into pandas-dev:master Oct 26, 2018
@jorisvandenbossche
Copy link
Member

Thanks @CalmDownKarm !

thoo added a commit to thoo/pandas that referenced this pull request Oct 26, 2018
…_pr4

* repo_org/master:
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
thoo added a commit to thoo/pandas that referenced this pull request Oct 26, 2018
…_series_pr1

* repo_org/master:
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
thoo added a commit to thoo/pandas that referenced this pull request Oct 26, 2018
…_pr2

* repo_org/master:
  DOC: Add docstring validations for "See Also" section (pandas-dev#23143)
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
  Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341)
  TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304)
  API: Add sparse Acessor (pandas-dev#23183)
  PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235)
thoo added a commit to thoo/pandas that referenced this pull request Oct 27, 2018
…ndas

* repo_org/master: (23 commits)
  DOC: Add docstring validations for "See Also" section (pandas-dev#23143)
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
  Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341)
  TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304)
  API: Add sparse Acessor (pandas-dev#23183)
  PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235)
  fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302)
  BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317)
  TST: re-enable gbq tests (pandas-dev#23303)
  Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311)
  isort imports-io (pandas-dev#23332)
  DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279)
  REF: Make PeriodArray an ExtensionArray (pandas-dev#22862)
  DOC: Added Examples for Series max (pandas-dev#23298)
  API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644)
  BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291)
  ...
thoo added a commit to thoo/pandas that referenced this pull request Oct 27, 2018
…xamples

* repo_org/master: (83 commits)
  DOC: Add docstring validations for "See Also" section (pandas-dev#23143)
  TST: Fix test assertion (pandas-dev#23357)
  BUG: Handle Period in combine (pandas-dev#23350)
  REF: SparseArray imports (pandas-dev#23329)
  CI: Migrate some CircleCI jobs to Azure (pandas-dev#22992)
  DOC: update the is_month_start/is_month_end docstring (pandas-dev#23051)
  Partialy fix issue pandas-dev#23334 - isort pandas/core/groupby directory (pandas-dev#23341)
  TST: Add base test for extensionarray setitem pandas-dev#23300 (pandas-dev#23304)
  API: Add sparse Acessor (pandas-dev#23183)
  PERF: speed up CategoricalIndex.get_loc (pandas-dev#23235)
  fix and test incorrect case in delta_to_nanoseconds (pandas-dev#23302)
  BUG: Handle Datetimelike data in DataFrame.combine (pandas-dev#23317)
  TST: re-enable gbq tests (pandas-dev#23303)
  Switched references of App veyor to azure pipelines in the contributing CI section (pandas-dev#23311)
  isort imports-io (pandas-dev#23332)
  DOC: Added a Multi Index example for the Series.sum method (pandas-dev#23279)
  REF: Make PeriodArray an ExtensionArray (pandas-dev#22862)
  DOC: Added Examples for Series max (pandas-dev#23298)
  API/ENH: tz_localize handling of nonexistent times: rename keyword + add shift option (pandas-dev#22644)
  BUG: Let MultiIndex.set_levels accept any iterable (pandas-dev#23273) (pandas-dev#23291)
  ...
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants