Skip to content

Support ExtensionArray in hash_pandas_object #23082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

TomAugspurger
Copy link
Contributor

Closes #23066

@TomAugspurger TomAugspurger added the ExtensionArray Extending pandas with custom dtypes or arrays. label Oct 11, 2018
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Oct 11, 2018
@pep8speaks
Copy link

Hello @TomAugspurger! Thanks for submitting the PR.

@jreback
Copy link
Contributor

jreback commented Oct 11, 2018

lgtm.

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #23082 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23082      +/-   ##
==========================================
+ Coverage   92.19%   92.19%   +<.01%     
==========================================
  Files         169      169              
  Lines       50911    50914       +3     
==========================================
+ Hits        46939    46942       +3     
  Misses       3972     3972
Flag Coverage Δ
#multiple 90.61% <100%> (ø) ⬆️
#single 42.3% <50%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/base.py 95.89% <ø> (ø) ⬆️
pandas/core/util/hashing.py 98.4% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 296c251...5935feb. Read the comment docs.

@jreback jreback merged commit 4001252 into pandas-dev:master Oct 11, 2018
@jreback
Copy link
Contributor

jreback commented Oct 11, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants