Skip to content

Add 'name' as argument for index 'to_frame' method #22580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 14, 2018
Merged

Add 'name' as argument for index 'to_frame' method #22580

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
11284cc
add the possibility to change name when converting index to frame
henriqueribeiro Sep 3, 2018
36bbc14
fix flake8
henriqueribeiro Sep 3, 2018
ecaaa69
change the way of verifying if name is None
henriqueribeiro Sep 3, 2018
7d24424
add 'names' argument on to_frame function for MultiIndex
henriqueribeiro Sep 6, 2018
bf691f4
add more tests for indexes' to_frame function using name argument
henriqueribeiro Sep 6, 2018
edad46b
fix some issues. For details check GH #22580
henriqueribeiro Sep 7, 2018
6f90ef1
Merge remote-tracking branch 'origin/master' into feature/name_on_ind…
henriqueribeiro Sep 8, 2018
b0eaa7c
correct lint
henriqueribeiro Sep 8, 2018
1b5ecf8
fix some typos and docstrings
henriqueribeiro Sep 11, 2018
f6ba766
fix wrong checking
henriqueribeiro Sep 11, 2018
8e12e0f
add release note
henriqueribeiro Sep 11, 2018
b46e729
improve release note message
henriqueribeiro Sep 12, 2018
db54f2a
merge
henriqueribeiro Sep 12, 2018
b1365ea
fix doc string
henriqueribeiro Sep 13, 2018
b5e9d9a
fixx error messages
henriqueribeiro Sep 13, 2018
59620b5
parametrize tests
henriqueribeiro Sep 13, 2018
65d4b92
fix merge on multindex
henriqueribeiro Sep 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,7 +1116,7 @@ def to_series(self, index=None, name=None):

return Series(self._to_embed(), index=index, name=name)

def to_frame(self, index=True):
def to_frame(self, index=True, name=None):
"""
Create a DataFrame with a column containing the Index.

Expand All @@ -1127,6 +1127,10 @@ def to_frame(self, index=True):
index : boolean, default True
Set the index of the returned DataFrame as the original Index.

name : object, default None
The passed name should substitute for the series name (if it has
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'series' -> 'index'

one).

Returns
-------
DataFrame
Expand Down Expand Up @@ -1154,10 +1158,17 @@ def to_frame(self, index=True):
0 Ant
1 Bear
2 Cow

>>> idx.to_frame(index=False, name='zoo')
zoo
0 Ant
1 Bear
2 Cow
"""

from pandas import DataFrame
name = self.name or 0
if not name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would have to be if name is not None, to allow falsey names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! I will change that

name = self.name or 0
result = DataFrame({name: self.values.copy()})

if index:
Expand Down