Add 'name' as argument for index 'to_frame' method #22580

henriqueribeiro · 2018-09-03T11:19:23Z

closes #xxxx
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

Since series to_frame method has a name argument, I believe it makes sense for index also have it.

TomAugspurger · 2018-09-03T12:54:28Z

The problem is that a name argument doesn’t make sense for a MultiIndex. Not sure what’s best here.

TomAugspurger · 2018-09-03T12:56:32Z

pandas/core/indexes/base.py

        """

        from pandas import DataFrame
-        name = self.name or 0
+        if not name:


This would have to be if name is not None, to allow falsey names.

You are right! I will change that

codecov · 2018-09-03T13:36:43Z

Codecov Report

Merging #22580 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #22580      +/-   ##
==========================================
+ Coverage   92.17%   92.17%   +<.01%     
==========================================
  Files         169      169              
  Lines       50708    50716       +8     
==========================================
+ Hits        46740    46748       +8     
  Misses       3968     3968

Flag	Coverage Δ
#multiple	`90.58% <100%> (ø)`	⬆️
#single	`42.34% <18.18%> (-0.01%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/indexes/multi.py	`95.43% <100%> (+0.02%)`	⬆️
pandas/core/indexes/base.py	`96.45% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23a0e8...db54f2a. Read the comment docs.

henriqueribeiro · 2018-09-03T13:39:44Z

@TomAugspurger regarding MultiIndex, I'm not seeing how this name will affect MultiIndex. Can you enlight me please?

jbrockmendel · 2018-09-03T17:20:45Z

Override for MI with plural names?

TomAugspurger · 2018-09-04T10:43:33Z

Probably best to keep the signature the same for MI, but indicate that `name` should be a sequence of strings matching the number of levels. Can you add a test for that, and implement it if it's broken?

…

On Mon, Sep 3, 2018 at 12:20 PM jbrockmendel ***@***.***> wrote: Override for MI with plural names? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22580 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIsYSWknpOduW3KyEA1uzSpohgEfQks5uXWTxgaJpZM4WXb1h> .

gfyoung · 2018-09-05T16:53:55Z

@henriqueribeiro : Thanks for the contribution! In the future, if you could open an issue before opening the PR, that would allow us to evaluate the idea first before implementing.

pep8speaks · 2018-09-06T13:38:10Z

Hello @henriqueribeiro! Thanks for updating the PR.

There are no PEP8 issues in the file pandas/core/indexes/base.py !
There are no PEP8 issues in the file pandas/core/indexes/multi.py !
There are no PEP8 issues in the file pandas/tests/indexes/common.py !
There are no PEP8 issues in the file pandas/tests/indexes/multi/test_conversion.py !

Comment last updated on September 08, 2018 at 15:33 Hours UTC

henriqueribeiro · 2018-09-06T13:38:47Z

@gfyoung Sure! Sorry for that

henriqueribeiro · 2018-09-07T09:46:56Z

@TomAugspurger I cannot understand why some checks are failing. Can you give me some help please?

TomAugspurger · 2018-09-07T10:42:36Z

There was a new release of openpyxl that's incompatible with pandas. It's been worked around on master, so you need to fetch upstream and push your changes.

git fetch upstream
git merge upstream/master
git push origin

pandas/core/indexes/base.py

pandas/core/indexes/multi.py

pandas/tests/indexes/common.py

pandas/tests/indexes/multi/test_conversion.py

pandas/core/indexes/multi.py

TomAugspurger · 2018-09-07T20:44:38Z

@henriqueribeiro linting error https://travis-ci.org/pandas-dev/pandas/jobs/425773293#L3653 and it looks like you may need to merge master still.

…ex_to_frame

TomAugspurger · 2018-09-10T11:05:55Z

pandas/core/indexes/base.py


        Parameters
        ----------
        index : boolean, default True
            Set the index of the returned DataFrame as the original Index.

+        name : object, default None
+            The passed name should substitute for the series name (if it has


'series' -> 'index'

pandas/core/indexes/base.py

pandas/core/indexes/multi.py

TomAugspurger · 2018-09-10T11:11:11Z

Needs a release note too, for 0.24

henriqueribeiro · 2018-09-11T10:23:04Z

@TomAugspurger Regarding the release notes, should I add this on the indexing section of v0.24.0.txt?

TomAugspurger · 2018-09-11T10:56:45Z

Probably under the "Other Enhancements" section.

…

On Tue, Sep 11, 2018 at 5:23 AM henriqueribeiro ***@***.***> wrote: @TomAugspurger <https://github.com/TomAugspurger> Regarding the release notes, should I add this on the indexing section of v0.24.0.txt? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22580 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIrIxCtuDKYcHf8Zju-pGGLo8Rin7ks5uZ48PgaJpZM4WXb1h> .

doc/source/whatsnew/v0.24.0.txt

pandas/core/indexes/multi.py

pandas/tests/indexes/common.py

jreback · 2018-09-13T16:22:12Z

lgtm. was there not a referenced issue?

henriqueribeiro · 2018-09-13T16:25:43Z

No. This came from dask and that's why I created the pull request immediately.

gfyoung · 2018-09-14T04:44:59Z

All green, and since @jreback has already approved this, merging.

gfyoung · 2018-09-14T04:45:30Z

Thanks @henriqueribeiro !

henriqueribeiro · 2018-09-14T12:36:17Z

Thanks to @TomAugspurger for this "ping-pong" fixing.

…2580)

henriqueribeiro added 2 commits September 3, 2018 12:08

add the possibility to change name when converting index to frame

11284cc

fix flake8

36bbc14

TomAugspurger reviewed Sep 3, 2018

View reviewed changes

change the way of verifying if name is None

ecaaa69

gfyoung added Enhancement Needs Discussion Requires discussion from core team before further action Compat pandas objects compatability with Numpy or Python functions labels Sep 5, 2018

henriqueribeiro added 2 commits September 6, 2018 14:36

add 'names' argument on to_frame function for MultiIndex

7d24424

add more tests for indexes' to_frame function using name argument

bf691f4

jreback requested changes Sep 7, 2018

View reviewed changes

TomAugspurger reviewed Sep 7, 2018

View reviewed changes

pandas/core/indexes/multi.py Outdated Show resolved Hide resolved

fix some issues. For details check GH pandas-dev#22580

edad46b

henriqueribeiro added 2 commits September 8, 2018 16:28

Merge remote-tracking branch 'origin/master' into feature/name_on_ind…

6f90ef1

…ex_to_frame

correct lint

b0eaa7c

TomAugspurger reviewed Sep 10, 2018

View reviewed changes

fix some typos and docstrings

1b5ecf8

henriqueribeiro added 2 commits September 11, 2018 12:06

fix wrong checking

f6ba766

add release note

8e12e0f

TomAugspurger reviewed Sep 11, 2018

View reviewed changes

doc/source/whatsnew/v0.24.0.txt Outdated Show resolved Hide resolved

henriqueribeiro added 2 commits September 12, 2018 11:16

improve release note message

b46e729

merge

db54f2a

TomAugspurger reviewed Sep 12, 2018

View reviewed changes

pandas/core/indexes/multi.py Outdated Show resolved Hide resolved

pandas/tests/indexes/common.py Outdated Show resolved Hide resolved

henriqueribeiro added 4 commits September 13, 2018 17:14

fix doc string

b1365ea

fixx error messages

b5e9d9a

parametrize tests

59620b5

fix merge on multindex

65d4b92

jreback added this to the 0.24.0 milestone Sep 13, 2018

jreback approved these changes Sep 13, 2018

View reviewed changes

gfyoung merged commit 08bd3e3 into pandas-dev:master Sep 14, 2018

aeltanawy pushed a commit to aeltanawy/pandas that referenced this pull request Sep 20, 2018

API: Add 'name' as argument for index 'to_frame' method (pandas-dev#2…

b151427

…2580)

Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018

API: Add 'name' as argument for index 'to_frame' method (pandas-dev#2…

2c6eda2

…2580)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'name' as argument for index 'to_frame' method #22580

Add 'name' as argument for index 'to_frame' method #22580

henriqueribeiro commented Sep 3, 2018 •

edited

Loading

TomAugspurger commented Sep 3, 2018

TomAugspurger Sep 3, 2018

henriqueribeiro Sep 3, 2018

codecov bot commented Sep 3, 2018 •

edited

Loading

henriqueribeiro commented Sep 3, 2018

jbrockmendel commented Sep 3, 2018

TomAugspurger commented Sep 4, 2018 via email

gfyoung commented Sep 5, 2018

pep8speaks commented Sep 6, 2018 •

edited

Loading

henriqueribeiro commented Sep 6, 2018

henriqueribeiro commented Sep 7, 2018

TomAugspurger commented Sep 7, 2018

TomAugspurger commented Sep 7, 2018

TomAugspurger Sep 10, 2018

TomAugspurger commented Sep 10, 2018

henriqueribeiro commented Sep 11, 2018

TomAugspurger commented Sep 11, 2018 via email

jreback commented Sep 13, 2018

henriqueribeiro commented Sep 13, 2018

gfyoung commented Sep 14, 2018

gfyoung commented Sep 14, 2018

henriqueribeiro commented Sep 14, 2018

Add 'name' as argument for index 'to_frame' method #22580

Add 'name' as argument for index 'to_frame' method #22580

Conversation

henriqueribeiro commented Sep 3, 2018 • edited Loading

TomAugspurger commented Sep 3, 2018

TomAugspurger Sep 3, 2018

Choose a reason for hiding this comment

henriqueribeiro Sep 3, 2018

Choose a reason for hiding this comment

codecov bot commented Sep 3, 2018 • edited Loading

Codecov Report

henriqueribeiro commented Sep 3, 2018

jbrockmendel commented Sep 3, 2018

TomAugspurger commented Sep 4, 2018 via email

gfyoung commented Sep 5, 2018

pep8speaks commented Sep 6, 2018 • edited Loading

Comment last updated on September 08, 2018 at 15:33 Hours UTC

henriqueribeiro commented Sep 6, 2018

henriqueribeiro commented Sep 7, 2018

TomAugspurger commented Sep 7, 2018

TomAugspurger commented Sep 7, 2018

TomAugspurger Sep 10, 2018

Choose a reason for hiding this comment

TomAugspurger commented Sep 10, 2018

henriqueribeiro commented Sep 11, 2018

TomAugspurger commented Sep 11, 2018 via email

jreback commented Sep 13, 2018

henriqueribeiro commented Sep 13, 2018

gfyoung commented Sep 14, 2018

gfyoung commented Sep 14, 2018

henriqueribeiro commented Sep 14, 2018

henriqueribeiro commented Sep 3, 2018 •

edited

Loading

codecov bot commented Sep 3, 2018 •

edited

Loading

pep8speaks commented Sep 6, 2018 •

edited

Loading