Remove weird comment in parse_dates.py #22418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was added back in pandas-devgh-12915...not sure why.
Codecov Report
@@ Coverage Diff @@
## master #22418 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 169 169
Lines 50713 50713
=======================================
Hits 46683 46683
Misses 4030 4030
Continue to review full report at Codecov.
|
jreback
reviewed
Aug 19, 2018
| @@ -365,7 +365,7 @@ def test_parse_tz_aware(self): | |||
| assert stamp.minute == 39 | |||
| try: | |||
| assert result.index.tz is pytz.utc | |||
| except AssertionError: # hello Yaroslav | |||
| except AssertionError: | |||
There was a problem hiding this comment.
actually why do we have an assertion error check here at all?
There was a problem hiding this comment.
Not sure...that code is at least 2 years old.
I imagine that pytz compatibility has improved since then...
There was a problem hiding this comment.
can u try to remove this and see
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Aug 19, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Was added back in pandas-devgh-12915...not sure why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was added back in #12915...not sure why I did that. 😕