BUG: Enforce parse_dates as bool when scalar #12915
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1036,7 +1036,7 @@ def test_parse_dates_string(self): | |||
| 20090103,c,4,5 | |||
| """ | |||
| rs = self.read_csv( | |||
There was a problem hiding this comment.
can you move all of the parse_dates testing to a separate class (make it a base class, kind of like ParserTests e.g. it inherits from object and have ParserTests inherit from it. Ideally we would group tests like this to keep them together. Can do this in another PR if you want to organize things even more.
There was a problem hiding this comment.
in any event move the parse_dates tests all together at least.
There was a problem hiding this comment.
I moved what I think are all of the pure parse_dates test together.
gfyoung
force-pushed
the
parse-dates-validate
branch
2 times, most recently
from
4e793c1 to
24571bd
Compare
| @@ -129,7 +129,7 @@ API changes | |||
|
|
|||
| - ``Period`` and ``PeriodIndex`` now raises ``IncompatibleFrequency`` error which inherits ``ValueError`` rather than raw ``ValueError`` (:issue:`12615`) | |||
|
|
|||
|
|
|||
| - ``read_csv`` will now raise a ``TypeError`` if ``parse_dates`` is neither a boolean, list, or dictionary (:issue:`5636`) | |||
There was a problem hiding this comment.
Nothing consistent AFAICT.
|
ok, lgtm. ping when greeen. |
Closes pandas-devgh-5636. In addition, this commit also adds validation to ensure that parse_dates is one of bool, list, or dict.
gfyoung
force-pushed
the
parse-dates-validate
branch
from
24571bd to
321ec2f
Compare
|
@jreback : Travis finally got the OSX build done, and everything is green! Ready to merge. |
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Aug 19, 2018
Was added back in pandas-devgh-12915...not sure why.
gfyoung
added a commit
that referenced
this pull request
Aug 19, 2018
Was added back in gh-12915...not sure why.
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Was added back in pandas-devgh-12915...not sure why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory. Closes #5636.