Skip to content

Finish moving period_helper to cython #22196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 7, 2018
Merged

Finish moving period_helper to cython #22196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7cc0d9e
finish moving period_helper to cython
jbrockmendel Aug 4, 2018
fcea3d6
flake8 fixups
jbrockmendel Aug 5, 2018
85bf081
update lint.sh
jbrockmendel Aug 5, 2018
cd6cc9b
flake8 fixup
jbrockmendel Aug 5, 2018
1bb05fb
cpplint fixups... i hope
jbrockmendel Aug 5, 2018
48e273b
cpplint fixup
jbrockmendel Aug 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ci/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,19 @@ if [ "$LINT" ]; then
# this particular codebase (e.g. src/headers, src/klib, src/msgpack). However,
# we can lint all header files since they aren't "generated" like C files are.
echo "Linting *.c and *.h"
for path in '*.h' 'period_helper.c' 'datetime' 'parser' 'ujson'
for path in '*.h' 'parser' 'ujson'
do
echo "linting -> pandas/_libs/src/$path"
cpplint --quiet --extensions=c,h --headers=h --filter=-readability/casting,-runtime/int,-build/include_subdir --recursive pandas/_libs/src/$path
if [ $? -ne "0" ]; then
RET=1
fi
done
echo "linting -> pandas/_libs/tslibs/src/datetime"
cpplint --quiet --extensions=c,h --headers=h --filter=-readability/casting,-runtime/int,-build/include_subdir --recursive pandas/_libs/tslibs/src/datetime
if [ $? -ne "0" ]; then
RET=1
fi
echo "Linting *.c and *.h DONE"

echo "Check for invalid testing"
Expand Down
Loading