-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Finish moving period_helper to cython #22196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
https://travis-ci.org/pandas-dev/pandas/jobs/412170226#L3465 Looks like you have some linting failures. |
Codecov Report
@@ Coverage Diff @@
## master #22196 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 169 169
Lines 50694 50694
=======================================
Hits 46671 46671
Misses 4023 4023
Continue to review full report at Codecov.
|
https://travis-ci.org/pandas-dev/pandas/jobs/412207881#L3475 Looks like you (still) have some linting failures. 🙁 |
https://travis-ci.org/pandas-dev/pandas/jobs/412219771#L3474 Getting there, but not quite. Are you able to check locally via cpplint? |
can you create an issue to add more period benchmarks |
Done |
thanks! |
There is probably some cleanup that can be done now that period logic is self-contained.
No evident perf impact.
(will post results from a couple more runs as they become available)
update two more runs show zero change, not even noise.
update Oh, also did some unrelated modernizing of string formatting in timedeltas.