Skip to content

Finish moving period_helper to cython #22196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 7, 2018
Merged

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Aug 4, 2018

There is probably some cleanup that can be done now that period logic is self-contained.

No evident perf impact.

asv continuous -E virtualenv -f 1.1 master HEAD -b period
[...]
       before           after         ratio
     [776fed3a]       [7cc0d9e8]
+        1.14±0μs      1.28±0.01μs     1.13  period.PeriodProperties.time_property('M', 'qyear')
-        579±30ms          509±4ms     0.88  groupby.Datelike.time_sum('period_range')

(will post results from a couple more runs as they become available)
update two more runs show zero change, not even noise.

update Oh, also did some unrelated modernizing of string formatting in timedeltas.

@gfyoung gfyoung added Period Period data type Clean labels Aug 4, 2018
@gfyoung
Copy link
Member

gfyoung commented Aug 4, 2018

https://travis-ci.org/pandas-dev/pandas/jobs/412170226#L3465

Looks like you have some linting failures.

@codecov
Copy link

codecov bot commented Aug 5, 2018

Codecov Report

Merging #22196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22196   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         169      169           
  Lines       50694    50694           
=======================================
  Hits        46671    46671           
  Misses       4023     4023
Flag Coverage Δ
#multiple 90.47% <ø> (ø) ⬆️
#single 42.32% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776fed3...48e273b. Read the comment docs.

@gfyoung
Copy link
Member

gfyoung commented Aug 5, 2018

https://travis-ci.org/pandas-dev/pandas/jobs/412207881#L3475

Looks like you (still) have some linting failures. 🙁

@gfyoung
Copy link
Member

gfyoung commented Aug 5, 2018

https://travis-ci.org/pandas-dev/pandas/jobs/412219771#L3474

Getting there, but not quite. Are you able to check locally via cpplint?

@jreback jreback added this to the 0.24.0 milestone Aug 6, 2018
@jreback
Copy link
Contributor

jreback commented Aug 6, 2018

asv continuous -E virtualenv -f 1.1 master HEAD -b period

can you create an issue to add more period benchmarks

@jbrockmendel
Copy link
Member Author

can you create an issue to add more period benchmarks

Done

@jreback jreback merged commit 313b4fe into pandas-dev:master Aug 7, 2018
@jreback
Copy link
Contributor

jreback commented Aug 7, 2018

thanks!

@jbrockmendel jbrockmendel deleted the phelperd branch August 8, 2018 15:51
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

period_helper should be in cython
3 participants