Skip to content

[BLD] [CLN] Close assorted issues - bare exceptions, unused func #22030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 26, 2018

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jul 23, 2018

- Removing numpy cimport from cython modules where feasible fixes the npy_deprecated1.7 ... warning. update Nope!

closes #19676
closes #21991

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@gfyoung gfyoung added Internals Related to non-user accessible pandas implementation Clean labels Jul 23, 2018
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of me wants to make this more modular, but the changes are small enough that this isn't an issue. LGTM!



class docstring_wrapper(object):
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah was going to use this a while back, but didn't need

@jreback
Copy link
Contributor

jreback commented Jul 24, 2018

hmm still quite a few warnings (I am guessing that this AND the other PR will make progress on more of these?)

ideally we could run the --with-cython-coverage on a build at some point. though would have to find a way to display this.

@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #22030 into master will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22030      +/-   ##
==========================================
+ Coverage   92.02%   92.04%   +0.02%     
==========================================
  Files         170      170              
  Lines       50707    50687      -20     
==========================================
- Hits        46661    46654       -7     
+ Misses       4046     4033      -13
Flag Coverage Δ
#multiple 90.45% <33.33%> (+0.02%) ⬆️
#single 42.31% <33.33%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/_decorators.py 91.34% <ø> (+9.08%) ⬆️
pandas/io/s3.py 86.36% <0%> (ø) ⬆️
pandas/util/_print_versions.py 15.71% <0%> (ø) ⬆️
pandas/core/tools/timedeltas.py 98.41% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c7387...65aad05. Read the comment docs.

@jbrockmendel jbrockmendel changed the title [BLD] [CLN] Close assorted issues - bare exceptions, unused func, npy1.7 warning [BLD] [CLN] Close assorted issues - bare exceptions, unused func Jul 24, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 25, 2018
@jreback
Copy link
Contributor

jreback commented Jul 25, 2018

lgtm. can you rebase again, just want to see what kinds of warnings on build travis has now (this is the last in the series to remove warnings?)

@jbrockmendel
Copy link
Member Author

Will rebase in a bit, ok. But note that the build-related parts of the PR were reverted they broke on windows.

@jreback jreback merged commit 495a0c1 into pandas-dev:master Jul 26, 2018
@jreback
Copy link
Contributor

jreback commented Jul 26, 2018

thank @jbrockmendel

@jreback
Copy link
Contributor

jreback commented Jul 26, 2018

@jbrockmendel build warnings are almost gone now! thanks!

@jbrockmendel jbrockmendel deleted the issues3 branch July 26, 2018 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLD: Make CLI option to enable coverage Unused util
3 participants