-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
[BLD] [CLN] Close assorted issues - bare exceptions, unused func #22030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of me wants to make this more modular, but the changes are small enough that this isn't an issue. LGTM!
|
||
|
||
class docstring_wrapper(object): | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah was going to use this a while back, but didn't need
hmm still quite a few warnings (I am guessing that this AND the other PR will make progress on more of these?) ideally we could run the --with-cython-coverage on a build at some point. though would have to find a way to display this. |
Codecov Report
@@ Coverage Diff @@
## master #22030 +/- ##
==========================================
+ Coverage 92.02% 92.04% +0.02%
==========================================
Files 170 170
Lines 50707 50687 -20
==========================================
- Hits 46661 46654 -7
+ Misses 4046 4033 -13
Continue to review full report at Codecov.
|
lgtm. can you rebase again, just want to see what kinds of warnings on build travis has now (this is the last in the series to remove warnings?) |
Will rebase in a bit, ok. But note that the build-related parts of the PR were reverted they broke on windows. |
thank @jbrockmendel |
@jbrockmendel build warnings are almost gone now! thanks! |
- Removing numpy cimport from cython modules where feasible fixes the npy_deprecated1.7 ... warning.update Nope!closes #19676
closes #21991
git diff upstream/master -u -- "*.py" | flake8 --diff