Skip to content

Unused util #19676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue Feb 13, 2018 · 3 comments · Fixed by #22030
Closed

Unused util #19676

jbrockmendel opened this issue Feb 13, 2018 · 3 comments · Fixed by #22030
Labels
Clean Internals Related to non-user accessible pandas implementation
Milestone

Comments

@jbrockmendel
Copy link
Member

util._doctools.TablePlotter is used only in it's own __main__ block. Does that need to exist?

_decorators.docstring_wrapper is unused.

@WillAyd
Copy link
Member

WillAyd commented Feb 14, 2018

It does appear that this is technically used in merging.rst, though the block referencing it is suppressed. That said, do we have any tools to analyze and clean up unused code? Wonder if something like vulture is worth exploring for pandas

@jreback
Copy link
Contributor

jreback commented Feb 14, 2018

we mostly just use linting

but adding a cleanup tool (to be run in the ci) would be great!

@WillAyd
Copy link
Member

WillAyd commented Feb 14, 2018

I'll open a separate change for that. Running vulture pandas --exclude pandas/tests from the top level directory yields 469 items, and I imagine there has to be some false positives in there.

If someone goes through the modules called out by the tool and can learn in more detail how the tool works it appears to be something that can get integrated with CI

@gfyoung gfyoung added Clean Internals Related to non-user accessible pandas implementation labels Feb 14, 2018
jbrockmendel added a commit to jbrockmendel/pandas that referenced this issue Jul 23, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
4 participants