CLN: miscellaneous cleanups / fixes #21861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21861 +/- ##
==========================================
- Coverage 91.92% 91.91% -0.01%
==========================================
Files 160 160
Lines 49906 49909 +3
==========================================
+ Hits 45875 45876 +1
- Misses 4031 4033 +2
Continue to review full report at Codecov.
|
jreback
changed the title
jreback
approved these changes
Jul 12, 2018
| """ | ||
|
|
||
| return (isinstance(obj, Iterable) and | ||
| not isinstance(obj, string_and_binary_types)) |
There was a problem hiding this comment.
in the future PR can you add some comments around what each of these clauses do
| @@ -7679,6 +7679,9 @@ def convert(v): | |||
| try: | |||
| if is_list_like(values[0]) or hasattr(values[0], 'len'): | |||
| values = np.array([convert(v) for v in values]) | |||
| elif isinstance(values[0], np.ndarray) and values[0].ndim == 0: | |||
There was a problem hiding this comment.
maybe could add is_numpy_scalar method in common
|
thanks @jbrockmendel keep em coming! |
4 tasks
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Jul 17, 2018
3 tasks
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21365 made good progress on #21336 so I copied the test from there and referenced it in the whatsnew.
closes #19700
closes #19011
closes #21336
git diff upstream/master -u -- "*.py" | flake8 --diff