Fix Issue #21336: Defeault behavior for resolution property in Timestamps #21365
Conversation
drewmassey
changed the title
|
Looks good overall! Looks like the CI failed due to some linting errors. |
doc/source/whatsnew/v0.23.1.txt
Outdated
| @@ -116,3 +116,4 @@ Other | |||
|
|
|||
| - Tab completion on :class:`Index` in IPython no longer outputs deprecation warnings (:issue:`21125`) | |||
| - Bug preventing pandas from being importable with -OO optimization (:issue:`21071`) | |||
| - Timestamp resolution returns a :class:`Timedelta` rather than a normal `timedelta` object (:issue:`21336`) | |||
There was a problem hiding this comment.
I think the main point of the issue was that before the stated resolution was 1 microsecond while in actuality its 1 nanosecond (but we can't use timedelta to express that because it doesn't support nanoseconds)
Codecov Report
@@ Coverage Diff @@
## master #21365 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 153 153
Lines 49600 49596 -4
==========================================
- Hits 45580 45576 -4
Misses 4020 4020
Continue to review full report at Codecov.
|
|
@mroeschke This passed linting on my local machine, but now there is a simple conflict to resolve under what's new that I can't do because I don't have repo write access. Is this something you can resolve, or point me to someone who can? Thanks. |
|
It's possible to fix the merge conflict locally and then re-push the resolution back to this branch. The general flow instructions can be found here: https://pandas.pydata.org/pandas-docs/stable/contributing.html#updating-your-pull-request Once you execute the |
doc/source/whatsnew/v0.23.1.txt
Outdated
| @@ -131,3 +131,5 @@ Bug Fixes | |||
| **Other** | |||
|
|
|||
| - Tab completion on :class:`Index` in IPython no longer outputs deprecation warnings (:issue:`21125`) | |||
| - Bug preventing pandas from being importable with -OO optimization (:issue:`21071`) | |||
There was a problem hiding this comment.
Looks like this already in the **Other Fixes** section.
|
LGTM. Only nitpick would be with the wording "native pandas", but I don't have any better ideas. |
|
Could I get a resolution on this from a contributor? Happy to fiddle the PR if necessary but don't want it to get stale. |
doc/source/whatsnew/v0.23.1.txt
Outdated
| @@ -132,4 +132,5 @@ Bug Fixes | |||
| **Other** | |||
|
|
|||
| - Tab completion on :class:`Index` in IPython no longer outputs deprecation warnings (:issue:`21125`) | |||
| - Timestamp resolution returns a :class:`Timedelta` (in nanoseconds) rather than a normal `timedelta` object (in microseconds) (:issue:`21336`) | |||
There was a problem hiding this comment.
Would you mind moving this entry to the v0.23.2.txt whatsnew? The 0.23.1 release is going out today or tomorrow I believe, and it appears the backports have already been established. Thanks for your patience.
|
Hmm looks like this branch picked up the commits of your other PR #21444. You'll need to revert the HEAD of this branch to a prior commit. |
|
can you rebase |
git diff upstream/master -u -- "*.py" | flake8 --diff