DOC: Add favicon to doc pages #21440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelostblom
changed the title
Codecov Report
@@ Coverage Diff @@
## master #21440 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 153 153
Lines 49600 49600
=======================================
Hits 45580 45580
Misses 4020 4020
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
Jun 13, 2018
|
Thanks! |
david-liu-brattle-1
pushed a commit
to david-liu-brattle-1/pandas
that referenced
this pull request
Jun 18, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion for adding a favicon to the doc pages. Having a favicon makes the pandas browser tabs easier to locate, especially with many open tabs or many pinned tabs.
I used the image from the pandas-dev GitHub organization, cropped some of the bars to make it appear less cluttered in the small favicon format, and resized it to a 32x32
.ico-file (the cropped png is attached at the end of this issue).A few screenshots (pinned and normal tabs, alternating with and without the favicon):
Firefox Quantum
Chromium
Firefox pre-Quantum
This is somewhat related to #21376, in that the favicon would change if a new logo is decided upon.
Cropped png
git diff upstream/master -u -- "*.py" | flake8 --diff