Skip to content

BUG: Fix #20744. loffset ignored in resample ffill #20884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2018

Conversation

johncant
Copy link
Contributor

This replaces pull request #20867

@jreback
Copy link
Contributor

jreback commented Apr 30, 2018

@johncant you could have just pushed to the original PR, no need to open a new one. next time pls do that.

@codecov
Copy link

codecov bot commented Apr 30, 2018

Codecov Report

Merging #20884 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20884      +/-   ##
==========================================
+ Coverage   91.78%   91.78%   +<.01%     
==========================================
  Files         153      153              
  Lines       49324    49325       +1     
==========================================
+ Hits        45272    45273       +1     
  Misses       4052     4052
Flag Coverage Δ
#multiple 90.17% <100%> (ø) ⬆️
#single 41.91% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/resample.py 96.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70468df...282e405. Read the comment docs.

@jreback jreback added Bug Resample resample method labels May 1, 2018
@jreback jreback added this to the 0.23.0 milestone May 1, 2018
@jreback jreback merged commit f799916 into pandas-dev:master May 1, 2018
@jreback
Copy link
Contributor

jreback commented May 1, 2018

thans @johncant !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Resample resample method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loffset in resample does not work with ffill, bfill, pad
2 participants