Fix #20744 . loffset ignored in upsample #20867
Conversation
|
Credit to Karan Singhal and @acidburnburn |
Codecov Report
@@ Coverage Diff @@
## master #20867 +/- ##
==========================================
+ Coverage 91.77% 91.77% +<.01%
==========================================
Files 153 153
Lines 49313 49314 +1
==========================================
+ Hits 45259 45260 +1
Misses 4054 4054
Continue to review full report at Codecov.
|
| assert_series_equal(result, expected) | ||
|
|
||
| expected = s.resample( | ||
| expected_downsample = Series([s[0], s[1:6].mean(), |
There was a problem hiding this comment.
can you make a separate test instead
There was a problem hiding this comment.
pls use result & expected rather than changing things
| @@ -1200,6 +1200,7 @@ Groupby/Resample/Rolling | |||
| - Bug in :func:`DataFrameGroupBy.cumsum` and :func:`DataFrameGroupBy.cumprod` when ``skipna`` was passed (:issue:`19806`) | |||
| - Bug in :func:`DataFrame.resample` that dropped timezone information (:issue:`13238`) | |||
| - Bug in :func:`DataFrame.groupby` where transformations using ``np.all`` and ``np.any`` were raising a ``ValueError`` (:issue:`20653`) | |||
| - Bug in :func:`DatetimeIndexResampler._upsample` where ``loffset`` was being ignored (:issue:`20744`) | |||
There was a problem hiding this comment.
should be a user visible note. users dont' know what _upsample is as its an internal method. pls rephrase.
|
Consider it done! I'll also rewrite the msg to include [BUG] |
|
Replaced by pull request #20884 |
git diff upstream/master -u -- "*.py" | flake8 --diff