-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: display.notebook_repr_html -> display.html.notebook (GH11784) #20396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
GGordonGordon
wants to merge
3
commits into
pandas-dev:master
from
GGordonGordon:GH11784_deprecate_notebook_repr_html
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
c04ec02
CLN: display.notebook_repr_html -> display.html.notebook (GH11784)
GGordonGordon aed30ef
CLN: display.notebook_repr_html -> display.html.notebook (GH11784)
GGordonGordon 0ee1367
CLN: display.notebook_repr_html -> display.html.notebook (GH11784)
GGordonGordon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1243,7 +1243,7 @@ def test_to_string_line_width_no_index(self): | |
def test_to_string_float_formatting(self): | ||
tm.reset_display_options() | ||
fmt.set_option('display.precision', 5, 'display.column_space', 12, | ||
'display.notebook_repr_html', False) | ||
'display.html.notebook', False) | ||
|
||
df = DataFrame({'x': [0, 0.25, 3456.000, 12e+45, 1.64e+6, 1.7e+8, | ||
1.253456, np.pi, -1e6]}) | ||
|
@@ -1421,7 +1421,7 @@ def test_repr_html(self): | |
fmt.set_option('display.max_rows', 1, 'display.max_columns', 1) | ||
self.frame._repr_html_() | ||
|
||
fmt.set_option('display.notebook_repr_html', False) | ||
fmt.set_option('display.html.notebook', False) | ||
self.frame._repr_html_() | ||
|
||
tm.reset_display_options() | ||
|
@@ -1651,6 +1651,12 @@ def test_period(self): | |
"3 2013-04 2011-04 d") | ||
assert str(df) == exp | ||
|
||
@tm.capture_stdout | ||
def test_option_notebook_repr_html_deprecated(self): | ||
with tm.assert_produces_warning(FutureWarning, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reference issue number above. |
||
check_stacklevel=False): | ||
pd.options.display.notebook_repr_html | ||
|
||
|
||
def gen_series_formatting(): | ||
s1 = pd.Series(['a'] * 100) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename the doc to
html_notebook_doc
.