CLN: display.notebook_repr_html -> display.html.notebook (GH11784) #20396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate display.notebook_repr_html and moved it to display.html.notebook
Codecov Report
@@ Coverage Diff @@
## master #20396 +/- ##
==========================================
+ Coverage 91.79% 91.79% +<.01%
==========================================
Files 152 152
Lines 49205 49208 +3
==========================================
+ Hits 45169 45172 +3
Misses 4036 4036
Continue to review full report at Codecov.
|
gfyoung
added
IO HTML
gfyoung
reviewed
Mar 18, 2018
pandas/core/config_init.py
Outdated
| @@ -366,6 +371,8 @@ def table_schema_cb(key): | |||
| validator=is_int) | |||
| cf.register_option('html.use_mathjax', True, pc_html_use_mathjax_doc, | |||
| validator=is_bool) | |||
| cf.register_option('html.notebook', True, pc_nb_repr_h_doc, | |||
There was a problem hiding this comment.
Let's rename the doc to html_notebook_doc.
Rename doc variable from pc_nb_repr_h_doc -> html_notebook_doc
gfyoung
reviewed
Mar 18, 2018
| @@ -1651,6 +1651,12 @@ def test_period(self): | |||
| "3 2013-04 2011-04 d") | |||
| assert str(df) == exp | |||
|
|
|||
| @tm.capture_stdout | |||
| def test_option_notebook_repr_html_deprecated(self): | |||
| with tm.assert_produces_warning(FutureWarning, | |||
|
I personally have some doubts about this deprecation. 1) a lot of people use this, just changing it for cosmetic reasons can be annoying, 2) I actually find the current name much more self-explanatory. |
Reference GitHub Issue # in test case
|
closing, @jorisvandenbossche logic is compelling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate display.notebook_repr_html option and move it to
display.html.notebook
git diff upstream/master -u -- "*.py" | flake8 --diff