Skip to content

DOC: Add comparison with Stata page to documentation #19945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 29, 2018

Conversation

kylebarron
Copy link
Contributor

  • closes #####
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

I noticed that the pandas documentation has pages for Comparison with SAS, Comparison with R and Comparison with SQL, but nothing for newcomers from Stata.

This is heavily based off of the "Comparison with SAS" page, with all the examples and discussion fixed for Stata.

@kylebarron
Copy link
Contributor Author

When I recompile with python make.py html, the command line interface still asks me

Running Sphinx v1.7.1
I'm about to DELETE the following:
['comparison_with_stata.rst']

WARNING: I'd like to delete those to speed up processing (yes/no)?

Is there a configuration file somewhere that I should add this document to?

@jreback jreback added Docs IO Stata read_stata, to_stata labels Mar 1, 2018
@jreback
Copy link
Contributor

jreback commented Mar 1, 2018

you need to add to the pandas/doc/source/index.rst.template

.. _compare_with_stata:

Comparison with Stata
********************
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sections should be excatly underlined (otherwise you get warnings)

@codecov
Copy link

codecov bot commented Mar 1, 2018

Codecov Report

Merging #19945 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19945      +/-   ##
==========================================
+ Coverage   91.82%   91.84%   +0.02%     
==========================================
  Files         152      152              
  Lines       49261    49261              
==========================================
+ Hits        45233    45245      +12     
+ Misses       4028     4016      -12
Flag Coverage Δ
#multiple 90.23% <ø> (+0.02%) ⬆️
#single 41.9% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 66.81% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ac1dd...7d0b0fa. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Mar 1, 2018

can you render and post this section

@kylebarron
Copy link
Contributor Author

I rendered it with python make.py html, and it looks fine, but Github doesn't let me attach an html file to an issue. How should I post it?

It seems like the Travis build failed from the time limit?

The job exceeded the maximum time limit for jobs, and has been terminated.

https://travis-ci.org/pandas-dev/pandas/jobs/347824581#L2729

@kylebarron
Copy link
Contributor Author

@jreback What can I do to get this merged?

@kylebarron
Copy link
Contributor Author

The CircleCI build is failing on two TSPlot tests, which seem to be unrelated to this PR.

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice. I merged in master, which should fix the circle CI issues. ping on green.

@kylebarron
Copy link
Contributor Author

Ping!

@TomAugspurger TomAugspurger merged commit 1bf36b0 into pandas-dev:master Mar 29, 2018
@TomAugspurger
Copy link
Contributor

Thanks @kylebarron !

javadnoorb pushed a commit to javadnoorb/pandas that referenced this pull request Mar 29, 2018
* Add Comparison with Stata to documentation

* Add comparison_with_stata.rst to index.rst.template

* Fix section underlining

* Small fixes
kornilova203 pushed a commit to kornilova203/pandas that referenced this pull request Apr 23, 2018
* Add Comparison with Stata to documentation

* Add comparison_with_stata.rst to index.rst.template

* Fix section underlining

* Small fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO Stata read_stata, to_stata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants