Skip to content

Move conda build and ASV check to cron job #19698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2018

Conversation

TomAugspurger
Copy link
Contributor

xref #19695 (not closing until pip build test is moved or we decide to keep that here)

https://travis-ci.org/pandas-dev/pandas-ci and http://github.com/pandas-dev/pandas-ci

@TomAugspurger TomAugspurger added the CI Continuous Integration label Feb 14, 2018
@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Feb 14, 2018
@TomAugspurger
Copy link
Contributor Author

https://travis-ci.org/pandas-dev/pandas-ci is passing now and set to run daily.

Will merge this once travis passes.

@codecov
Copy link

codecov bot commented Feb 14, 2018

Codecov Report

Merging #19698 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19698      +/-   ##
==========================================
+ Coverage   91.58%    91.6%   +0.02%     
==========================================
  Files         150      150              
  Lines       48867    48867              
==========================================
+ Hits        44755    44767      +12     
+ Misses       4112     4100      -12
Flag Coverage Δ
#multiple 89.98% <ø> (+0.02%) ⬆️
#single 41.75% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d198a6e...b151fd8. Read the comment docs.

@TomAugspurger
Copy link
Contributor Author

FYI, I renamed 3.5_CONDA_BUILD to 3.5 and removed the 3.6_ASV job entirely.

@TomAugspurger
Copy link
Contributor Author

OK, this is all green other than the pip failure from #19668 (looking further into that later today hopefully) https://travis-ci.org/pandas-dev/pandas/builds/341580276

Thoughts on adding --skip-network to the "2.7" build? It's the slowest by ~15 minutes. We'll want to make sure at least one of the 2.7 builds has the flag.

FYI, this weekend I'm planning on revamping some of this stuff into a more declarative YAML form. Then we can have a small script that parses those and prints out which builds have which flags / pinned deps.

@TomAugspurger TomAugspurger merged commit 11de131 into pandas-dev:master Feb 14, 2018
@TomAugspurger TomAugspurger deleted the ci-move branch February 14, 2018 19:56
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
* CI: Remove ASV run

* CI: Removed conda build test

* Removed asv.sh step

* Removed the ASV matrix item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant