Skip to content

BLD: move asv build to a daily travis cron #19695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Feb 14, 2018 · 13 comments
Closed

BLD: move asv build to a daily travis cron #19695

jreback opened this issue Feb 14, 2018 · 13 comments
Labels
Build Library building on various platforms CI Continuous Integration
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Feb 14, 2018

No description provided.

@jreback jreback added Build Library building on various platforms CI Continuous Integration labels Feb 14, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 14, 2018
@TomAugspurger
Copy link
Contributor

Are you working on this, or should I?

@jreback
Copy link
Contributor Author

jreback commented Feb 14, 2018

feel free!

I would create another repo (in pandas-dev) to do this
similar to the wheel building

i suppose u could reuse that code

@TomAugspurger
Copy link
Contributor

Good idea. Thoughts on moving over

  1. ASV
  2. conda-build
  3. pip build

Anything else?

@jreback
Copy link
Contributor Author

jreback commented Feb 14, 2018

i think those plus 32 bit build would be awesome

maybe just run these on a daily cron

@jreback
Copy link
Contributor Author

jreback commented Feb 14, 2018

maybe doc build as well?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Feb 14, 2018 via email

@jreback
Copy link
Contributor Author

jreback commented Feb 14, 2018

even better!

note that we do this also in ibis-project

@TomAugspurger
Copy link
Contributor

👍 . I'll be offline for a couple hours, but will start on this afterwards.

Tangentially related, I'd like to go through all our ci/* stuff and simplify / consolidate our dependency code.

I want to get to the point where we have a single environment.yaml per build, and try to get everything installed in a single shot by conda, instead of multiple steps. That'll help with previously pinned deps getting upgraded without us knowing.

And then we can small script that will print out the various versions of deps we're tested against.

I'd also like to better manage optional dependencies and test-only dependencies, but not sure the best way forward yet.

@jreback
Copy link
Contributor Author

jreback commented Feb 14, 2018

all for cleaning up
but be careful
a lot of that code is designed to give informative errors when things fail and to no pin things too much

@jorisvandenbossche
Copy link
Member

I think Joris had plans (or hopes?) to move the doc build to circle-CI and upload an artifact so that users can check the doc build, similar to how scikit-learn does it.

Even apart from that, I often check the doc build to then comment on the PR with things that break the docs, so I would prefer to keep this in the pandas CI itself.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Feb 14, 2018 via email

@jreback
Copy link
Contributor Author

jreback commented Feb 14, 2018

yeah not concerned about the doc build really. the other builds are just taking extra time on each commit and doing daily would be sufficient.

@TomAugspurger
Copy link
Contributor

I think everything here is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

No branches or pull requests

3 participants