TST: Clean up pickle compression tests #19350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 23, 2018
pandas/tests/frame/test_to_csv.py
Outdated
| @@ -925,22 +925,23 @@ def test_to_csv_compression(self, compression): | |||
| [12.32112, 123123.2, 321321.2]], | |||
| index=['A', 'B'], columns=['X', 'Y', 'Z']) | |||
|
|
|||
| with ensure_clean() as filename: | |||
| if compression != "zip": | |||
There was a problem hiding this comment.
you could do
if compression == 'zip':
pytest.skip("not zip compression test for to_csv")
....
| df.to_json(path, compression=compression) | ||
| assert_frame_equal(df, pd.read_json(path, compression=compression)) | ||
| if compression != 'zip': | ||
| with tm.ensure_clean() as path: |
There was a problem hiding this comment.
same here (alternatively, you can make another fixed w/o zip), maybe compression_no_zip is better
reidy-p
force-pushed
the
pickle_compress_test_clean
branch
from
15e45a3 to
16328e0
Compare
jreback
approved these changes
Jan 24, 2018
|
lgtm. ping on green (or at least all linux builds on travis), seems mac may have some issues. |
Codecov Report
@@ Coverage Diff @@
## master #19350 +/- ##
==========================================
- Coverage 91.57% 91.56% -0.01%
==========================================
Files 150 150
Lines 48705 48704 -1
==========================================
- Hits 44600 44598 -2
- Misses 4105 4106 +1
Continue to review full report at Codecov.
|
|
@jreback it's green now, thanks! |
|
Thanks @reidy-p ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #19226
Move compression fixture to top-level
conftest.pyClean-up compression tests in
pandas/tests/io/test_pickle.pyand add zip to thedecompress_filetesting utilityMake some minor adjustments to the json and csv compression tests to skip zip compression when it's not valid