Skip to content

TST: clean up all of the compression tests #19226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Jan 13, 2018 · 5 comments · Fixed by #20337
Closed

TST: clean up all of the compression tests #19226

jreback opened this issue Jan 13, 2018 · 5 comments · Fixed by #20337
Labels
Clean good first issue Testing pandas testing functions or related to the test suite
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jan 13, 2018

we have tests for compression kwargs all over the code base, e.g. grep -r compression pandas/tests/

I think only the json and parser network tests parametrize these. The others have copy-pasted code all over the place.

Needs to be consolidated, and the fixtures that are used in json/parser should be pushed to the very top level conftest.py

would accept incremental (multiple) PR's for this.

@reidy-p
Copy link
Contributor

reidy-p commented Jan 30, 2018

@jreback do you see any more compression tests that should be cleaned? There are some other compression tests that I haven't touched but I don't see any way to clean them up easily.

@jreback
Copy link
Contributor Author

jreback commented Jan 31, 2018

I think tests still in :pandas/tests/io/parser/compression.py and test_pickle

@jreback
Copy link
Contributor Author

jreback commented Jan 31, 2018

in test_pickle there is a TestCompression class, did that get missed?

@jreback
Copy link
Contributor Author

jreback commented Mar 13, 2018

@reidy-p anything remaining on this?

@reidy-p
Copy link
Contributor

reidy-p commented Mar 13, 2018

@jreback I think some of the tests in pandas/tests/io/parser/compression.py can be parametrized. I will try to submit a PR for this.

We could also move the compress_file function in pandas/tests/io/test_pickle.py to pandas/util/testing.py to make it closer to the decompress_file utility function and possibly re-use it for other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean good first issue Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants