-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: clean up all of the compression tests #19226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jreback do you see any more compression tests that should be cleaned? There are some other compression tests that I haven't touched but I don't see any way to clean them up easily. |
I think tests still in :pandas/tests/io/parser/compression.py and test_pickle |
in test_pickle there is a TestCompression class, did that get missed? |
@reidy-p anything remaining on this? |
@jreback I think some of the tests in We could also move the |
we have tests for compression kwargs all over the code base, e.g.
grep -r compression pandas/tests/
I think only the json and parser network tests parametrize these. The others have copy-pasted code all over the place.
Needs to be consolidated, and the fixtures that are used in json/parser should be pushed to the very top level conftest.py
would accept incremental (multiple) PR's for this.
The text was updated successfully, but these errors were encountered: