Skip to content

Revert "CI: temp disable scipy on windows 3.6 build (#18078)" #18105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Nov 4, 2017

This reverts commit cd6dc87.

closes #18073

@jreback jreback added the Windows Windows OS label Nov 4, 2017
@jreback jreback added this to the 0.21.1 milestone Nov 4, 2017
@jreback
Copy link
Contributor Author

jreback commented Nov 4, 2017

so using numpy 1.13 worked. I guess there is a mismatch between the scipy picked up and numpy 1.12, maybe the new conda's doing.

@jreback jreback merged commit 2d6f836 into pandas-dev:master Nov 4, 2017
@codecov
Copy link

codecov bot commented Nov 4, 2017

Codecov Report

Merging #18105 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18105      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +<.01%     
==========================================
  Files         163      163              
  Lines       50123    50123              
==========================================
+ Hits        45741    45744       +3     
+ Misses       4382     4379       -3
Flag Coverage Δ
#multiple 89.07% <ø> (+0.02%) ⬆️
#single 40.32% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3268f4e...1b61ea4. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 4, 2017

Codecov Report

Merging #18105 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18105      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +<.01%     
==========================================
  Files         163      163              
  Lines       50123    50123              
==========================================
+ Hits        45741    45744       +3     
+ Misses       4382     4379       -3
Flag Coverage Δ
#multiple 89.07% <ø> (+0.02%) ⬆️
#single 40.32% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3268f4e...1b61ea4. Read the comment docs.

@jreback jreback mentioned this pull request Nov 4, 2017
1kastner pushed a commit to 1kastner/pandas that referenced this pull request Nov 5, 2017
…" (pandas-dev#18105)

* Revert "CI: temp disable scipy on windows 3.6 build (pandas-dev#18078)"

This reverts commit cd6dc87.

* use numpy=1.13
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
…" (pandas-dev#18105)

* Revert "CI: temp disable scipy on windows 3.6 build (pandas-dev#18078)"

This reverts commit cd6dc87.

* use numpy=1.13
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017
…" (pandas-dev#18105)

* Revert "CI: temp disable scipy on windows 3.6 build (pandas-dev#18078)"

This reverts commit cd6dc87.

* use numpy=1.13

(cherry picked from commit 2d6f836)
TomAugspurger pushed a commit that referenced this pull request Dec 11, 2017
* Revert "CI: temp disable scipy on windows 3.6 build (#18078)"

This reverts commit cd6dc87.

* use numpy=1.13

(cherry picked from commit 2d6f836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Scipy Installation Failures on AppVeyor
1 participant