Skip to content

Fix c build warnings #17634; remove several unused funcs #17932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2017

Conversation

jbrockmendel
Copy link
Member

Removes several unused functions, most importantly floatify which util attempts to import from numpy_helper but which does not exist there.

While putting this together I noticed in parsers.pyx a couple occurrences ofprint >> sys.stderr, self.parser.warn_msg. I guess this is still valid cython, but should probably be updated anyway.

@codecov
Copy link

codecov bot commented Oct 20, 2017

Codecov Report

Merging #17932 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17932      +/-   ##
==========================================
- Coverage   91.23%   91.22%   -0.02%     
==========================================
  Files         163      163              
  Lines       50113    50113              
==========================================
- Hits        45723    45714       -9     
- Misses       4390     4399       +9
Flag Coverage Δ
#multiple 89.03% <ø> (ø) ⬆️
#single 40.31% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b4bb3...4145068. Read the comment docs.

@jreback jreback added the Clean label Oct 21, 2017
@jreback jreback added this to the 0.21.0 milestone Oct 21, 2017
@jreback jreback merged commit 5314578 into pandas-dev:master Oct 21, 2017
@jreback
Copy link
Contributor

jreback commented Oct 21, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLD: parser c-build warnings
2 participants