Skip to content

BLD: parser c-build warnings #17634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Sep 22, 2017 · 0 comments · Fixed by #17932
Closed

BLD: parser c-build warnings #17634

jreback opened this issue Sep 22, 2017 · 0 comments · Fixed by #17932
Labels
Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions IO CSV read_csv, to_csv
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Sep 22, 2017

These just need some casting I think

andas/_libs/src/parser/tokenizer.c:1091:41: warning: comparison of integers of different signs: 'int64_t' (aka 'long long') and 'unsigned long long' [-Wsign-compare]
                            self->lines == start_lines + line_limit) {
                            ~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~
pandas/_libs/src/parser/tokenizer.c:1180:15: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int64_t' (aka 'long long') [-Wsign-compare]
    if (nrows > self->lines) {
        ~~~~~ ^ ~~~~~~~~~~~
pandas/_libs/src/parser/tokenizer.c:1196:20: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int64_t' (aka 'long long') [-Wsign-compare]
    if (char_count < self->stream_len) {
        ~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~
pandas/_libs/src/parser/tokenizer.c:1244:17: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int64_t' (aka 'long long') [-Wsign-compare]
    if (new_cap < self->words_cap) {
        ~~~~~~~ ^ ~~~~~~~~~~~~~~~
pandas/_libs/src/parser/tokenizer.c:1268:17: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int64_t' (aka 'long long') [-Wsign-compare]
    if (new_cap < self->stream_cap) {
        ~~~~~~~ ^ ~~~~~~~~~~~~~~~~
pandas/_libs/src/parser/tokenizer.c:1296:17: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int64_t' (aka 'long long') [-Wsign-compare]
    if (new_cap < self->lines_cap) {
        ~~~~~~~ ^ ~~~~~~~~~~~~~~~
pandas/_libs/src/parser/tokenizer.c:1351:47: warning: comparison of integers of different signs: 'long long' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
        if (!all && self->lines - start_lines >= nrows) break;
@jreback jreback added Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions Difficulty Intermediate IO CSV read_csv, to_csv labels Sep 22, 2017
@jreback jreback modified the milestones: 0.21.0, Next Major Release Sep 22, 2017
jbrockmendel added a commit to jbrockmendel/pandas that referenced this issue Oct 20, 2017
@jreback jreback modified the milestones: Next Major Release, 0.21.0 Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant