-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: grammatical mistakes #17512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DOC: grammatical mistakes #17512
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
19c4494
DOC: grammatical mistakes
Giftlin 97b6d87
DOC: grammatical mistake
Giftlin 27ee846
Merge pull request #1 from Giftlin/Giftlin-patch-n
Giftlin c9a5ff9
Update stata.py
Giftlin b84bee9
Update stata.py
Giftlin 45979b0
Update stata.py
Giftlin 32f2164
Update stata.py
Giftlin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,7 +57,7 @@ | |
identifier of column that should be used as index of the DataFrame | ||
convert_missing : boolean, defaults to False | ||
Flag indicating whether to convert missing values to their Stata | ||
representations. If False, missing values are replaced with nans. | ||
representations. If False, missing values are replaced with nan. | ||
If True, columns containing missing values are returned with | ||
object data types and missing values are represented by | ||
StataMissingValue objects. | ||
|
@@ -249,7 +249,7 @@ def convert_year_month_safe(year, month): | |
""" | ||
Convert year and month to datetimes, using pandas vectorized versions | ||
when the date range falls within the range supported by pandas. Other | ||
wise it falls back to a slower but more robust method using datetime. | ||
-wise it falls back to a slower but more robust method using datetime. | ||
""" | ||
if year.max() < MAX_YEAR and year.min() > MIN_YEAR: | ||
return to_datetime(100 * year + month, format='%Y%m') | ||
|
@@ -261,7 +261,7 @@ def convert_year_month_safe(year, month): | |
|
||
def convert_year_days_safe(year, days): | ||
""" | ||
Converts year (e.g. 1999) and days since the start of the year to a | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a is correct here |
||
Converts year (e.g. 1999) and days since the start of the year to | ||
datetime or datetime64 Series | ||
""" | ||
if year.max() < (MAX_YEAR - 1) and year.min() > MIN_YEAR: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put Other on the same line here.