DOC: grammatical mistakes #17512
Merged
DOC: grammatical mistakes #17512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOC: grammatical mistake
jreback
reviewed
Sep 13, 2017
pandas/io/stata.py
Outdated
| @@ -249,7 +249,7 @@ def convert_year_month_safe(year, month): | |||
| """ | |||
| Convert year and month to datetimes, using pandas vectorized versions | |||
| when the date range falls within the range supported by pandas. Other | |||
| wise it falls back to a slower but more robust method using datetime. | |||
| -wise it falls back to a slower but more robust method using datetime. | |||
There was a problem hiding this comment.
can you put Other on the same line here.
jreback
reviewed
Sep 13, 2017
pandas/io/stata.py
Outdated
| @@ -261,7 +261,7 @@ def convert_year_month_safe(year, month): | |||
|
|
|||
| def convert_year_days_safe(year, days): | |||
| """ | |||
| Converts year (e.g. 1999) and days since the start of the year to a | |||
|
Hello @Giftlin! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on September 13, 2017 at 11:36 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #17512 +/- ##
==========================================
- Coverage 91.18% 88.92% -2.26%
==========================================
Files 163 163
Lines 49543 49543
==========================================
- Hits 45177 44058 -1119
- Misses 4366 5485 +1119
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17512 +/- ##
==========================================
- Coverage 91.18% 88.92% -2.26%
==========================================
Files 163 163
Lines 49543 49543
==========================================
- Hits 45177 44058 -1119
- Misses 4366 5485 +1119
Continue to review full report at Codecov.
|
|
thanks! |
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff