-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Change plot style to matplotlib decault from ggplot #17462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Change plot style to matplotlib decault from ggplot #17462
Conversation
can you post a screen shot of the change (just a single page is fine, just something for people to look) |
doc/source/visualization.rst
Outdated
Setting the plot style | ||
~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
From version 1.5 and up, matplotlib offers a range of preconfigured plotting style. Setting these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you point to the mpl docs here as well.
doc/source/visualization.rst
Outdated
these styles can be used to easily give the plots have the general look that you want. | ||
Setting the can style is as easy as calling ``matplotlib.style.use(my_plot_style)`` before | ||
creating your plot. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the examples of plot style are necessary here, again just point to the mpl docs.
37130a5
to
6212b79
Compare
Codecov Report
@@ Coverage Diff @@
## master #17462 +/- ##
==========================================
- Coverage 91.16% 91.14% -0.02%
==========================================
Files 163 163
Lines 49590 49590
==========================================
- Hits 45209 45200 -9
- Misses 4381 4390 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17462 +/- ##
==========================================
- Coverage 91.26% 91.24% -0.02%
==========================================
Files 163 163
Lines 49806 49806
==========================================
- Hits 45455 45446 -9
- Misses 4351 4360 +9
Continue to review full report at Codecov.
|
I couldn't find a suitable page where the built-in styles are demonstarted. But it's easy enough to do yourself, so I just deleted the examples. |
lgtm. @TomAugspurger |
We can use whatever version of matplotlib we want to built the docs, and I suppose we will typically use the latest. Given that, we can actually also use the new improved default matplotlib 2.0 style, instead of taking a custom one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor language comments.
doc/source/visualization.rst
Outdated
Setting the plot style | ||
~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
From version 1.5 and up, matplotlib offers a range of preconfigured plotting style. Setting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style -> styles
doc/source/visualization.rst
Outdated
~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
From version 1.5 and up, matplotlib offers a range of preconfigured plotting style. Setting the | ||
style can be used to easily give the plots the general look that you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the plots -> plots
Language changes from @jorisvandenbossche implenented. |
MPL 2 isn't bad but still seaborn is nicer looking. |
any objections to this. lgtm. |
I propose just merging this in. If anyone got an different view point, it's easy to make a new pull request. |
Time for a poll!
Voting closes in 48 hours ;) I vote for matplotlib 2.0 > seaborn > ggplot (3 > 2 > 1) |
Preferential voting n case of a tie 🥇 2 > 3 > 1 FWIW I think the current is ggplot, and this PR is proposing to use seaborn |
2 > 3 > 1. |
3 > 2 > 1 |
Any other votes ? |
can someone post a comparison on 1, 2, 3 (for a single plot) here. |
First example from the docs:
|
BTW, the reason I vote for 3 (matplotlib default) is not because I find it the nicest style (in that case I would actually vote for ggplot I think), but because I think it is good enough and it is the best option for our docs. When people run examples from the docs, they will most likely see the default style, and by using the default style in our docs, it will most likely match with what they see. |
ok i can be on board with 3 > 2 > 1 |
58fc048
to
3f56b60
Compare
ok, I've changed it, so the plot style is not, which means default style for mpl > 2. The line is commented out rather than deleted, so its easy to experiment with different styles by doing find/replace. |
@topper-123 Merged! |
A proposal to change plot style in the docs to
seaborn
fromggplot
.See also #17423.