-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Upgrade minimal version of matplotlib to 1.5.3 and use a seaborn-like style in docs #17423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Alternatively, if going to 1.5 is seen as too big of a change this time, could the doc plots still be built using matplotlib => 1.5 and making a note on how they're made. |
going to 1.5.3 is fine. we don't support python 3.4. |
note that this issue is 2 independent parts. The docs are built on 3.6 with specific requirements and can/should use the newest mpl syntax (we use the latest mpl), see requirements-3.6_DOC.build. |
Ok. I'll make a pull request where the style for the doc plots will have a seaborn style. I'll assume that I only have to change the |
@topper-123 seach for FWIW, I prefer the default matplotlib 2.0 style for some things like line plots. I might vote for it over 'seaborn', but would be curious what others prefer. |
Thanks @TomAugspurger. Then it's very easy, that's nice. I'll might wait a few days before commiting, if a discussion arises. I personally prefer I could maybe add a small snippet, showing 2-3 different styles, so readers who are unfamiliar with matplotlib can get a feel for the possibilities). |
No reason to bikeshed over this :) Feel free to submit a PR changing the
style to your favorite.
…On Tue, Sep 5, 2017 at 4:06 PM, topper-123 ***@***.***> wrote:
Thanks @TomAugspurger <https://github.com/tomaugspurger>. Then it's very
easy, that's nice. I'll might wait a few days before commiting, if a
discussion arises.
I personally prefer seaborn-deep, but will choose seaborn here, as that's
more standard choice. I would like to keep the style consistent for the
whole docs (unless there's a specific reason not to).
I could maybe add a small snippet, showing 2-3 different styles, so
readers who are unfamiliar with matplotlib can get a feel for the
possibilities).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17423 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIkAzDYLO3H8BDCtxGXyR5QtfwYnnks5sfbfCgaJpZM4PK-JG>
.
|
This issue was done in #17462, so i'm closing the issue. |
Matplotlib is an optional dependency of pandas. I propose making matplotlib 1.5.3 the recommended minimal version for pandas 0.21. Currently, v1.4.3 is the minimal version.
The reason are:
For differences between the different 1.x versions for matplotlib, see her.
So:
The text was updated successfully, but these errors were encountered: