TST: Enable tests that aren't currently running in indexes/datetimes/test_tools.py #17405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled tests that currently aren't running. Small fix to make sure all tests pass. Verified that the raised messages match expectations for TestToDatetimeUnit::test_frame.
jschendel
force-pushed
the
fix-format-tools-datetimes
branch
from
3d5a52c to
a09ac59
Compare
Codecov Report
@@ Coverage Diff @@
## master #17405 +/- ##
==========================================
+ Coverage 91.03% 91.14% +0.11%
==========================================
Files 163 163
Lines 49580 49580
==========================================
+ Hits 45137 45192 +55
+ Misses 4443 4388 -55
Continue to review full report at Codecov.
|
|
Thanks @jschendel! |
jowens
pushed a commit
to jowens/pandas
that referenced
this pull request
Sep 20, 2017
Enabled tests that currently aren't running. Small fix to make sure all tests pass. Verified that the raised messages match expectations for TestToDatetimeUnit::test_frame.
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
Enabled tests that currently aren't running. Small fix to make sure all tests pass. Verified that the raised messages match expectations for TestToDatetimeUnit::test_frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffEnabled tests that aren't currently running. Made a small modification to a typo in
datetimes.pyto make sure all tests pass. Small modifications to checks inTestToDatetimeUnit::test_frameto verify that the raised messages match expectations.