Skip to content

TST: Some tests in indexes/datetimes/test_tools.py don't appear to run #17403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jschendel opened this issue Aug 31, 2017 · 1 comment · Fixed by #17405
Closed

TST: Some tests in indexes/datetimes/test_tools.py don't appear to run #17403

jschendel opened this issue Aug 31, 2017 · 1 comment · Fixed by #17405
Labels
Testing pandas testing functions or related to the test suite
Milestone

Comments

@jschendel
Copy link
Member

Code Sample, a copy-pastable example if possible

class TimeConversionFormats(object):
def test_to_datetime_format(self):

class ToDatetimeUnit(object):
def test_unit(self):

Problem description

None of the tests in the classes linked above appear to run. I noticed this because there's a formatting typo that should have been caught by one of the tests:

"[{excess}]".format(','.join(excess=excess)))

Renaming the classes to TestTimeConversionFormats and TestToDatetimeUnit makes them run locally for me, and the formatting typo gets caught.

I'd be happy to submit a PR to enable these tests and fix the formatting typo. Wanted to check here first to make sure that these weren't purposefully disabled, and that I'm not missing something obvious.

@chris-b1
Copy link
Contributor

This is not intentional but a left over from our conversion to pytest similar to #16478. Please do submit a PR!

@chris-b1 chris-b1 added the Testing pandas testing functions or related to the test suite label Aug 31, 2017
@chris-b1 chris-b1 added this to the 0.21.0 milestone Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants