-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Return local Timestamp.weekday_name attribute (#17354) #17377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
120e12d
fb4095a
e453d10
18852f4
9d0031f
ddaa4e3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -532,9 +532,7 @@ class Timestamp(_Timestamp): | |
|
||
@property | ||
def weekday_name(self): | ||
out = get_date_name_field( | ||
np.array([self.value], dtype=np.int64), 'weekday_name') | ||
return out[0] | ||
return self._get_named_field('weekday_name') | ||
|
||
@property | ||
def dayofyear(self): | ||
|
@@ -1268,13 +1266,27 @@ cdef class _Timestamp(datetime): | |
# same timezone if specified) | ||
return datetime.__sub__(self, other) | ||
|
||
cpdef _get_field(self, field): | ||
cdef int64_t _maybe_convert_value_to_local(self): | ||
"""Convert UTC i8 value to local i8 value if tz exists""" | ||
val = self.value | ||
if self.tz is not None and not _is_utc(self.tz): | ||
val = tz_convert_single(self.value, 'UTC', self.tz) | ||
return val | ||
|
||
cpdef _get_field(self, field): | ||
cdef: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. like this |
||
int64_t val | ||
val = self._maybe_convert_value_to_local() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can type val as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if you can type out in these (ndarray[int32_t]) i think |
||
out = get_date_field(np.array([val], dtype=np.int64), field) | ||
return int(out[0]) | ||
|
||
cpdef _get_named_field(self, field): | ||
cdef: | ||
int64_t val | ||
val = self._maybe_convert_value_to_local() | ||
out = get_date_name_field(np.array([val], dtype=np.int64), field) | ||
return out[0] | ||
|
||
cpdef _get_start_end_field(self, field): | ||
month_kw = self.freq.kwds.get( | ||
'startingMonth', self.freq.kwds.get( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add a
here in order to type it