-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Return local Timestamp.weekday_name attribute (#17354) #17377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
120e12d
BUG: Return local Timestamp.weekday_name attribute (#17354)
mroeschke fb4095a
Add whatsnew
mroeschke e453d10
Type ctype variables and functions, whatsnew fix
mroeschke 18852f4
Balance triple quotes
mroeschke 9d0031f
Ctype array and leftover val
mroeschke ddaa4e3
untype array
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -532,9 +532,7 @@ class Timestamp(_Timestamp): | |
|
||
@property | ||
def weekday_name(self): | ||
out = get_date_name_field( | ||
np.array([self.value], dtype=np.int64), 'weekday_name') | ||
return out[0] | ||
return self._get_named_field('weekday_name') | ||
|
||
@property | ||
def dayofyear(self): | ||
|
@@ -1268,13 +1266,29 @@ cdef class _Timestamp(datetime): | |
# same timezone if specified) | ||
return datetime.__sub__(self, other) | ||
|
||
cpdef _get_field(self, field): | ||
cdef int64_t _maybe_convert_value_to_local(self): | ||
"""Convert UTC i8 value to local i8 value if tz exists""" | ||
cdef: | ||
int64_t val | ||
val = self.value | ||
if self.tz is not None and not _is_utc(self.tz): | ||
val = tz_convert_single(self.value, 'UTC', self.tz) | ||
return val | ||
|
||
cpdef _get_field(self, field): | ||
cdef: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. like this |
||
int64_t val | ||
val = self._maybe_convert_value_to_local() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if you can type out in these (ndarray[int32_t]) i think |
||
out = get_date_field(np.array([val], dtype=np.int64), field) | ||
return int(out[0]) | ||
|
||
cpdef _get_named_field(self, field): | ||
cdef: | ||
int64_t val | ||
val = self._maybe_convert_value_to_local() | ||
out = get_date_name_field(np.array([val], dtype=np.int64), field) | ||
return out[0] | ||
|
||
cpdef _get_start_end_field(self, field): | ||
month_kw = self.freq.kwds.get( | ||
'startingMonth', self.freq.kwds.get( | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add a
here in order to type it