Skip to content

MAINT: Remove assertIs from testing #16105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Apr 24, 2017

Title is self-explanatory.

Partially addresses #15990.

@codecov
Copy link

codecov bot commented Apr 24, 2017

Codecov Report

Merging #16105 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16105      +/-   ##
==========================================
- Coverage   90.86%   90.84%   -0.03%     
==========================================
  Files         159      159              
  Lines       50773    50770       -3     
==========================================
- Hits        46136    46121      -15     
- Misses       4637     4649      +12
Flag Coverage Δ
#multiple 88.62% <ø> (-0.03%) ⬇️
#single 40.34% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 79.13% <ø> (-0.06%) ⬇️
pandas/plotting/_converter.py 63.54% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a926b...2a1f1a8. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 24, 2017

Codecov Report

Merging #16105 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16105      +/-   ##
==========================================
- Coverage   90.86%   90.84%   -0.03%     
==========================================
  Files         159      159              
  Lines       50773    50770       -3     
==========================================
- Hits        46136    46121      -15     
- Misses       4637     4649      +12
Flag Coverage Δ
#multiple 88.62% <ø> (-0.03%) ⬇️
#single 40.34% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 79.13% <ø> (-0.06%) ⬇️
pandas/plotting/_converter.py 63.54% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a926b...2a1f1a8. Read the comment docs.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Apr 24, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 24, 2017
@jreback jreback merged commit e8edf13 into pandas-dev:master Apr 24, 2017
@jreback
Copy link
Contributor

jreback commented Apr 24, 2017

thanks!

@gfyoung gfyoung deleted the assertIs-remove branch April 24, 2017 15:48
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants