Skip to content

Commit 3c144f8

Browse files
gfyoungpcluo
authored andcommitted
MAINT: Remove assertIs from testing (pandas-dev#16105)
1 parent 5b66616 commit 3c144f8

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+219
-227
lines changed

pandas/tests/dtypes/test_common.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def test_datetimetz_dtype(self):
2626
for dtype in ['datetime64[ns, US/Eastern]',
2727
'datetime64[ns, Asia/Tokyo]',
2828
'datetime64[ns, UTC]']:
29-
self.assertIs(pandas_dtype(dtype), DatetimeTZDtype(dtype))
29+
assert pandas_dtype(dtype) is DatetimeTZDtype(dtype)
3030
self.assertEqual(pandas_dtype(dtype), DatetimeTZDtype(dtype))
3131
self.assertEqual(pandas_dtype(dtype), dtype)
3232

@@ -36,7 +36,7 @@ def test_categorical_dtype(self):
3636
def test_period_dtype(self):
3737
for dtype in ['period[D]', 'period[3M]', 'period[U]',
3838
'Period[D]', 'Period[3M]', 'Period[U]']:
39-
self.assertIs(pandas_dtype(dtype), PeriodDtype(dtype))
39+
assert pandas_dtype(dtype) is PeriodDtype(dtype)
4040
self.assertEqual(pandas_dtype(dtype), PeriodDtype(dtype))
4141
self.assertEqual(pandas_dtype(dtype), dtype)
4242

pandas/tests/dtypes/test_dtypes.py

+8-14
Original file line numberDiff line numberDiff line change
@@ -249,20 +249,14 @@ def test_subclass(self):
249249
self.assertTrue(issubclass(type(a), type(b)))
250250

251251
def test_identity(self):
252-
self.assertEqual(PeriodDtype('period[D]'),
253-
PeriodDtype('period[D]'))
254-
self.assertIs(PeriodDtype('period[D]'),
255-
PeriodDtype('period[D]'))
252+
assert PeriodDtype('period[D]') == PeriodDtype('period[D]')
253+
assert PeriodDtype('period[D]') is PeriodDtype('period[D]')
256254

257-
self.assertEqual(PeriodDtype('period[3D]'),
258-
PeriodDtype('period[3D]'))
259-
self.assertIs(PeriodDtype('period[3D]'),
260-
PeriodDtype('period[3D]'))
255+
assert PeriodDtype('period[3D]') == PeriodDtype('period[3D]')
256+
assert PeriodDtype('period[3D]') is PeriodDtype('period[3D]')
261257

262-
self.assertEqual(PeriodDtype('period[1S1U]'),
263-
PeriodDtype('period[1000001U]'))
264-
self.assertIs(PeriodDtype('period[1S1U]'),
265-
PeriodDtype('period[1000001U]'))
258+
assert PeriodDtype('period[1S1U]') == PeriodDtype('period[1000001U]')
259+
assert PeriodDtype('period[1S1U]') is PeriodDtype('period[1000001U]')
266260

267261
def test_coerce_to_dtype(self):
268262
self.assertEqual(_coerce_to_dtype('period[D]'),
@@ -371,12 +365,12 @@ def test_construction(self):
371365
def test_construction_generic(self):
372366
# generic
373367
i = IntervalDtype('interval')
374-
self.assertIs(i.subtype, None)
368+
assert i.subtype is None
375369
self.assertTrue(is_interval_dtype(i))
376370
self.assertTrue(str(i) == 'interval')
377371

378372
i = IntervalDtype()
379-
self.assertIs(i.subtype, None)
373+
assert i.subtype is None
380374
self.assertTrue(is_interval_dtype(i))
381375
self.assertTrue(str(i) == 'interval')
382376

pandas/tests/frame/test_alter_axes.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def test_set_index(self):
3535
# cache it
3636
_ = self.mixed_frame['foo'] # noqa
3737
self.mixed_frame.index = idx
38-
self.assertIs(self.mixed_frame['foo'].index, idx)
38+
assert self.mixed_frame['foo'].index is idx
3939
with assertRaisesRegexp(ValueError, 'Length mismatch'):
4040
self.mixed_frame.index = idx[::2]
4141

pandas/tests/frame/test_api.py

+7-7
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ def test_get_axis(self):
8888
self.assertEqual(f._get_axis_name('rows'), 'index')
8989
self.assertEqual(f._get_axis_name('columns'), 'columns')
9090

91-
self.assertIs(f._get_axis(0), f.index)
92-
self.assertIs(f._get_axis(1), f.columns)
91+
assert f._get_axis(0) is f.index
92+
assert f._get_axis(1) is f.columns
9393

9494
assertRaisesRegexp(ValueError, 'No axis named', f._get_axis_number, 2)
9595
assertRaisesRegexp(ValueError, 'No axis.*foo', f._get_axis_name, 'foo')
@@ -99,7 +99,7 @@ def test_get_axis(self):
9999

100100
def test_keys(self):
101101
getkeys = self.frame.keys
102-
self.assertIs(getkeys(), self.frame.columns)
102+
assert getkeys() is self.frame.columns
103103

104104
def test_column_contains_typeerror(self):
105105
try:
@@ -122,17 +122,17 @@ def test_array_interface(self):
122122
with np.errstate(all='ignore'):
123123
result = np.sqrt(self.frame)
124124
assert isinstance(result, type(self.frame))
125-
self.assertIs(result.index, self.frame.index)
126-
self.assertIs(result.columns, self.frame.columns)
125+
assert result.index is self.frame.index
126+
assert result.columns is self.frame.columns
127127

128128
assert_frame_equal(result, self.frame.apply(np.sqrt))
129129

130130
def test_get_agg_axis(self):
131131
cols = self.frame._get_agg_axis(0)
132-
self.assertIs(cols, self.frame.columns)
132+
assert cols is self.frame.columns
133133

134134
idx = self.frame._get_agg_axis(1)
135-
self.assertIs(idx, self.frame.index)
135+
assert idx is self.frame.index
136136

137137
pytest.raises(ValueError, self.frame._get_agg_axis, 2)
138138

pandas/tests/frame/test_apply.py

+10-9
Original file line numberDiff line numberDiff line change
@@ -25,29 +25,30 @@ def test_apply(self):
2525
with np.errstate(all='ignore'):
2626
# ufunc
2727
applied = self.frame.apply(np.sqrt)
28-
assert_series_equal(np.sqrt(self.frame['A']), applied['A'])
28+
tm.assert_series_equal(np.sqrt(self.frame['A']), applied['A'])
2929

3030
# aggregator
3131
applied = self.frame.apply(np.mean)
32-
self.assertEqual(applied['A'], np.mean(self.frame['A']))
32+
assert applied['A'] == np.mean(self.frame['A'])
3333

3434
d = self.frame.index[0]
3535
applied = self.frame.apply(np.mean, axis=1)
36-
self.assertEqual(applied[d], np.mean(self.frame.xs(d)))
37-
self.assertIs(applied.index, self.frame.index) # want this
36+
assert applied[d] == np.mean(self.frame.xs(d))
37+
assert applied.index is self.frame.index # want this
3838

3939
# invalid axis
4040
df = DataFrame(
4141
[[1, 2, 3], [4, 5, 6], [7, 8, 9]], index=['a', 'a', 'c'])
4242
pytest.raises(ValueError, df.apply, lambda x: x, 2)
4343

44-
# GH9573
44+
# see gh-9573
4545
df = DataFrame({'c0': ['A', 'A', 'B', 'B'],
4646
'c1': ['C', 'C', 'D', 'D']})
4747
df = df.apply(lambda ts: ts.astype('category'))
48-
self.assertEqual(df.shape, (4, 2))
49-
self.assertTrue(isinstance(df['c0'].dtype, CategoricalDtype))
50-
self.assertTrue(isinstance(df['c1'].dtype, CategoricalDtype))
48+
49+
assert df.shape == (4, 2)
50+
assert isinstance(df['c0'].dtype, CategoricalDtype)
51+
assert isinstance(df['c1'].dtype, CategoricalDtype)
5152

5253
def test_apply_mixed_datetimelike(self):
5354
# mixed datetimelike
@@ -190,7 +191,7 @@ def _checkit(axis=0, raw=False):
190191
if is_reduction:
191192
agg_axis = df._get_agg_axis(axis)
192193
assert isinstance(res, Series)
193-
self.assertIs(res.index, agg_axis)
194+
assert res.index is agg_axis
194195
else:
195196
assert isinstance(res, DataFrame)
196197

pandas/tests/frame/test_axis_select_reindex.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ def test_reindex(self):
204204

205205
# Same index, copies values but not index if copy=False
206206
newFrame = self.frame.reindex(self.frame.index, copy=False)
207-
self.assertIs(newFrame.index, self.frame.index)
207+
assert newFrame.index is self.frame.index
208208

209209
# length zero
210210
newFrame = self.frame.reindex([])

pandas/tests/frame/test_indexing.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -1171,29 +1171,29 @@ def test_getitem_fancy_1d(self):
11711171

11721172
# return self if no slicing...for now
11731173
with catch_warnings(record=True):
1174-
self.assertIs(f.ix[:, :], f)
1174+
assert f.ix[:, :] is f
11751175

11761176
# low dimensional slice
11771177
with catch_warnings(record=True):
11781178
xs1 = f.ix[2, ['C', 'B', 'A']]
11791179
xs2 = f.xs(f.index[2]).reindex(['C', 'B', 'A'])
1180-
assert_series_equal(xs1, xs2)
1180+
tm.assert_series_equal(xs1, xs2)
11811181

11821182
with catch_warnings(record=True):
11831183
ts1 = f.ix[5:10, 2]
11841184
ts2 = f[f.columns[2]][5:10]
1185-
assert_series_equal(ts1, ts2)
1185+
tm.assert_series_equal(ts1, ts2)
11861186

11871187
# positional xs
11881188
with catch_warnings(record=True):
11891189
xs1 = f.ix[0]
11901190
xs2 = f.xs(f.index[0])
1191-
assert_series_equal(xs1, xs2)
1191+
tm.assert_series_equal(xs1, xs2)
11921192

11931193
with catch_warnings(record=True):
11941194
xs1 = f.ix[f.index[5]]
11951195
xs2 = f.xs(f.index[5])
1196-
assert_series_equal(xs1, xs2)
1196+
tm.assert_series_equal(xs1, xs2)
11971197

11981198
# single column
11991199
with catch_warnings(record=True):
@@ -1204,18 +1204,18 @@ def test_getitem_fancy_1d(self):
12041204
exp = f.copy()
12051205
exp.values[5] = 4
12061206
f.ix[5][:] = 4
1207-
assert_frame_equal(exp, f)
1207+
tm.assert_frame_equal(exp, f)
12081208

12091209
with catch_warnings(record=True):
12101210
exp.values[:, 1] = 6
12111211
f.ix[:, 1][:] = 6
1212-
assert_frame_equal(exp, f)
1212+
tm.assert_frame_equal(exp, f)
12131213

12141214
# slice of mixed-frame
12151215
with catch_warnings(record=True):
12161216
xs = self.mixed_frame.ix[5]
12171217
exp = self.mixed_frame.xs(self.mixed_frame.index[5])
1218-
assert_series_equal(xs, exp)
1218+
tm.assert_series_equal(xs, exp)
12191219

12201220
def test_setitem_fancy_1d(self):
12211221

@@ -1676,7 +1676,7 @@ def test_set_value(self):
16761676
def test_set_value_resize(self):
16771677

16781678
res = self.frame.set_value('foobar', 'B', 0)
1679-
self.assertIs(res, self.frame)
1679+
assert res is self.frame
16801680
self.assertEqual(res.index[-1], 'foobar')
16811681
self.assertEqual(res.get_value('foobar', 'B'), 0)
16821682

pandas/tests/frame/test_operators.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -907,7 +907,7 @@ def test_combineFunc(self):
907907
_check_mixed_float(result, dtype=dict(C=None))
908908

909909
result = self.empty * 2
910-
self.assertIs(result.index, self.empty.index)
910+
assert result.index is self.empty.index
911911
self.assertEqual(len(result.columns), 0)
912912

913913
def test_comparisons(self):
@@ -1117,16 +1117,16 @@ def test_inplace_ops_identity(self):
11171117
s += 1
11181118
assert_series_equal(s, s2)
11191119
assert_series_equal(s_orig + 1, s)
1120-
self.assertIs(s, s2)
1121-
self.assertIs(s._data, s2._data)
1120+
assert s is s2
1121+
assert s._data is s2._data
11221122

11231123
df = df_orig.copy()
11241124
df2 = df
11251125
df += 1
11261126
assert_frame_equal(df, df2)
11271127
assert_frame_equal(df_orig + 1, df)
1128-
self.assertIs(df, df2)
1129-
self.assertIs(df._data, df2._data)
1128+
assert df is df2
1129+
assert df._data is df2._data
11301130

11311131
# dtype change
11321132
s = s_orig.copy()
@@ -1140,8 +1140,8 @@ def test_inplace_ops_identity(self):
11401140
df += 1.5
11411141
assert_frame_equal(df, df2)
11421142
assert_frame_equal(df_orig + 1.5, df)
1143-
self.assertIs(df, df2)
1144-
self.assertIs(df._data, df2._data)
1143+
assert df is df2
1144+
assert df._data is df2._data
11451145

11461146
# mixed dtype
11471147
arr = np.random.randint(0, 10, size=5)
@@ -1152,15 +1152,15 @@ def test_inplace_ops_identity(self):
11521152
expected = DataFrame({'A': arr.copy() + 1, 'B': 'foo'})
11531153
assert_frame_equal(df, expected)
11541154
assert_frame_equal(df2, expected)
1155-
self.assertIs(df._data, df2._data)
1155+
assert df._data is df2._data
11561156

11571157
df = df_orig.copy()
11581158
df2 = df
11591159
df['A'] += 1.5
11601160
expected = DataFrame({'A': arr.copy() + 1.5, 'B': 'foo'})
11611161
assert_frame_equal(df, expected)
11621162
assert_frame_equal(df2, expected)
1163-
self.assertIs(df._data, df2._data)
1163+
assert df._data is df2._data
11641164

11651165
def test_alignment_non_pandas(self):
11661166
index = ['A', 'B', 'C']

pandas/tests/groupby/test_groupby.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -759,17 +759,18 @@ def test_len(self):
759759
def test_groups(self):
760760
grouped = self.df.groupby(['A'])
761761
groups = grouped.groups
762-
self.assertIs(groups, grouped.groups) # caching works
762+
assert groups is grouped.groups # caching works
763763

764764
for k, v in compat.iteritems(grouped.groups):
765-
self.assertTrue((self.df.loc[v]['A'] == k).all())
765+
assert (self.df.loc[v]['A'] == k).all()
766766

767767
grouped = self.df.groupby(['A', 'B'])
768768
groups = grouped.groups
769-
self.assertIs(groups, grouped.groups) # caching works
769+
assert groups is grouped.groups # caching works
770+
770771
for k, v in compat.iteritems(grouped.groups):
771-
self.assertTrue((self.df.loc[v]['A'] == k[0]).all())
772-
self.assertTrue((self.df.loc[v]['B'] == k[1]).all())
772+
assert (self.df.loc[v]['A'] == k[0]).all()
773+
assert (self.df.loc[v]['B'] == k[1]).all()
773774

774775
def test_basic_regression(self):
775776
# regression

pandas/tests/indexes/datetimes/test_datetime.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ def test_time_overflow_for_32bit_machines(self):
156156
self.assertEqual(len(idx2), periods)
157157

158158
def test_nat(self):
159-
self.assertIs(DatetimeIndex([np.nan])[0], pd.NaT)
159+
assert DatetimeIndex([np.nan])[0] is pd.NaT
160160

161161
def test_ufunc_coercions(self):
162162
idx = date_range('2011-01-01', periods=3, freq='2D', name='x')
@@ -617,7 +617,7 @@ def test_join_self(self):
617617
kinds = 'outer', 'inner', 'left', 'right'
618618
for kind in kinds:
619619
joined = index.join(index, how=kind)
620-
self.assertIs(index, joined)
620+
assert index is joined
621621

622622
def assert_index_parameters(self, index):
623623
assert index.freq == '40960N'

pandas/tests/indexes/datetimes/test_ops.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -879,8 +879,8 @@ def test_shift(self):
879879
tm.assert_index_equal(idx.shift(-3, freq='H'), exp)
880880

881881
def test_nat(self):
882-
self.assertIs(pd.DatetimeIndex._na_value, pd.NaT)
883-
self.assertIs(pd.DatetimeIndex([])._na_value, pd.NaT)
882+
assert pd.DatetimeIndex._na_value is pd.NaT
883+
assert pd.DatetimeIndex([])._na_value is pd.NaT
884884

885885
for tz in [None, 'US/Eastern', 'UTC']:
886886
idx = pd.DatetimeIndex(['2011-01-01', '2011-01-02'], tz=tz)

pandas/tests/indexes/datetimes/test_setops.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ def test_datetimeindex_union_join_empty(self):
185185

186186
result = dti.union(empty)
187187
assert isinstance(result, DatetimeIndex)
188-
self.assertIs(result, result)
188+
assert result is result
189189

190190
result = dti.join(empty)
191191
assert isinstance(result, DatetimeIndex)

pandas/tests/indexes/datetimes/test_tools.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -179,14 +179,14 @@ def test_to_datetime_dt64s(self):
179179
]
180180

181181
for dt in in_bound_dts:
182-
self.assertEqual(pd.to_datetime(dt), Timestamp(dt))
182+
assert pd.to_datetime(dt) == Timestamp(dt)
183183

184184
oob_dts = [np.datetime64('1000-01-01'), np.datetime64('5000-01-02'), ]
185185

186186
for dt in oob_dts:
187187
pytest.raises(ValueError, pd.to_datetime, dt, errors='raise')
188188
pytest.raises(ValueError, Timestamp, dt)
189-
self.assertIs(pd.to_datetime(dt, errors='coerce'), NaT)
189+
assert pd.to_datetime(dt, errors='coerce') is NaT
190190

191191
def test_to_datetime_array_of_dt64s(self):
192192
dts = [np.datetime64('2000-01-01'), np.datetime64('2000-01-02'), ]
@@ -681,7 +681,7 @@ def test_to_datetime_types(self):
681681

682682
# empty string
683683
result = to_datetime('')
684-
self.assertIs(result, NaT)
684+
assert result is NaT
685685

686686
result = to_datetime(['', ''])
687687
self.assertTrue(isnull(result).all())

pandas/tests/indexes/period/test_indexing.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -121,15 +121,15 @@ def test_getitem_datetime(self):
121121
def test_getitem_nat(self):
122122
idx = pd.PeriodIndex(['2011-01', 'NaT', '2011-02'], freq='M')
123123
self.assertEqual(idx[0], pd.Period('2011-01', freq='M'))
124-
self.assertIs(idx[1], tslib.NaT)
124+
assert idx[1] is tslib.NaT
125125

126126
s = pd.Series([0, 1, 2], index=idx)
127127
self.assertEqual(s[pd.NaT], 1)
128128

129129
s = pd.Series(idx, index=idx)
130130
self.assertEqual(s[pd.Period('2011-01', freq='M')],
131131
pd.Period('2011-01', freq='M'))
132-
self.assertIs(s[pd.NaT], tslib.NaT)
132+
assert s[pd.NaT] is tslib.NaT
133133

134134
def test_getitem_list_periods(self):
135135
# GH 7710

0 commit comments

Comments
 (0)