Skip to content

BUG: groupby-rolling with a timedelta #16091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2017
Merged

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Apr 22, 2017

closes #13966
xref to #15130, closed by #15175

@jreback jreback added Groupby Testing pandas testing functions or related to the test suite Datetime Datetime data dtype labels Apr 22, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 22, 2017
@jreback
Copy link
Contributor Author

jreback commented Apr 22, 2017

@chrisaycock

@codecov
Copy link

codecov bot commented Apr 22, 2017

Codecov Report

Merging #16091 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16091      +/-   ##
==========================================
+ Coverage   90.84%   90.84%   +<.01%     
==========================================
  Files         159      159              
  Lines       50776    50776              
==========================================
+ Hits        46128    46129       +1     
+ Misses       4648     4647       -1
Flag Coverage Δ
#multiple 88.62% <ø> (ø) ⬆️
#single 40.35% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f562308...b30a50f. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 22, 2017

Codecov Report

Merging #16091 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16091   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         159      159           
  Lines       50776    50776           
=======================================
  Hits        46128    46128           
  Misses       4648     4648
Flag Coverage Δ
#multiple 88.62% <ø> (ø) ⬆️
#single 40.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f562308...b30a50f. Read the comment docs.

@jreback jreback merged commit f0bd908 into pandas-dev:master Apr 22, 2017
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time-based .rolling() fails with .groupby()
1 participant