Skip to content

MAINT: Remove tm.assertIsNot from testing #16024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2017
Merged

MAINT: Remove tm.assertIsNot from testing #16024

merged 1 commit into from
Apr 16, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Apr 16, 2017 •
edited
Loading

Title is self-explanatory. Also clean up other non-pytest idioms where I was removing assertIsNot.

Partially addresses #15990.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Apr 16, 2017
@jreback
Copy link
Contributor

jreback commented Apr 16, 2017

lgtm. FYI, travis is undergoing maint.

@gfyoung gfyoung force-pushed the assertIsNot-remove branch from 5bf05a2 to d0f6e39 Compare April 16, 2017 21:04
@gfyoung gfyoung force-pushed the assertIsNot-remove branch from d0f6e39 to c678575 Compare April 16, 2017 21:11
@codecov
Copy link

codecov bot commented Apr 16, 2017 •
edited
Loading

Codecov Report

Merging #16024 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16024      +/-   ##
==========================================
+ Coverage   90.99%   90.99%   +<.01%     
==========================================
  Files         154      154              
  Lines       50471    50472       +1     
==========================================
+ Hits        45926    45927       +1     
  Misses       4545     4545
Flag Coverage Δ
#multiple 88.76% <100%> (ø) ⬆️
#single 40.43% <42.85%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 80.76% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25272b...c678575. Read the comment docs.

@jorisvandenbossche jorisvandenbossche merged commit 5146b59 into pandas-dev:master Apr 16, 2017
@codecov
Copy link

codecov bot commented Apr 16, 2017 •
edited
Loading

Codecov Report

Merging #16024 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16024      +/-   ##
==========================================
+ Coverage   90.99%   90.99%   +<.01%     
==========================================
  Files         154      154              
  Lines       50471    50472       +1     
==========================================
+ Hits        45926    45927       +1     
  Misses       4545     4545
Flag Coverage Δ
#multiple 88.76% <100%> (ø) ⬆️
#single 40.43% <42.85%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 80.76% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25272b...c678575. Read the comment docs.

@jorisvandenbossche
Copy link
Member

thanks!

@jorisvandenbossche jorisvandenbossche modified the milestones: 2.0, 0.20.0 Apr 16, 2017
@gfyoung gfyoung deleted the assertIsNot-remove branch April 16, 2017 22:09
@gfyoung
Copy link
Member Author

gfyoung commented Apr 16, 2017

@jorisvandenbossche : Shoot, it looks there were a few other instances of assertIsNot that didn't make the cut. I'll remove them in a follow-up.

@jorisvandenbossche
Copy link
Member

And all tests still passed?

@gfyoung
Copy link
Member Author

gfyoung commented Apr 16, 2017

It's because they're self.assertIsNot, not tm.assetIsNot

gfyoung added a commit to forking-repos/pandas that referenced this pull request Apr 16, 2017
@gfyoung
MAINT: Remove vestigial assertIsNot's
b966bca 
Follow-up to pandas-devgh-16024.
@gfyoung gfyoung mentioned this pull request Apr 17, 2017
Merged
jorisvandenbossche pushed a commit that referenced this pull request Apr 17, 2017
@gfyoung @jorisvandenbossche
MAINT: Remove assertIsNotNone from testing (#16027)
0e2bbcf 
Follow-up to gh-16024.

Also removes some vestigial assertIsNot calls missed in #16024.

Partially addresses #15990.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gfyoung @jreback @jorisvandenbossche