Skip to content

Commit c678575

Browse files
committed
MAINT: Remove tm.assertIsNot from testing
1 parent a25272b commit c678575

22 files changed

+194
-183
lines changed

pandas/tests/core/sparse/test_frame.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -422,24 +422,24 @@ def test_iloc(self):
422422

423423
def test_set_value(self):
424424

425-
# ok as the index gets conver to object
425+
# ok, as the index gets converted to object
426426
frame = self.frame.copy()
427427
res = frame.set_value('foobar', 'B', 1.5)
428-
self.assertEqual(res.index.dtype, 'object')
428+
assert res.index.dtype == 'object'
429429

430430
res = self.frame
431431
res.index = res.index.astype(object)
432432

433433
res = self.frame.set_value('foobar', 'B', 1.5)
434-
self.assertIsNot(res, self.frame)
435-
self.assertEqual(res.index[-1], 'foobar')
436-
self.assertEqual(res.get_value('foobar', 'B'), 1.5)
434+
assert res is not self.frame
435+
assert res.index[-1] == 'foobar'
436+
assert res.get_value('foobar', 'B') == 1.5
437437

438438
res2 = res.set_value('foobar', 'qux', 1.5)
439-
self.assertIsNot(res2, res)
440-
self.assert_index_equal(res2.columns,
441-
pd.Index(list(self.frame.columns) + ['qux']))
442-
self.assertEqual(res2.get_value('foobar', 'qux'), 1.5)
439+
assert res2 is not res
440+
tm.assert_index_equal(res2.columns,
441+
pd.Index(list(self.frame.columns) + ['qux']))
442+
assert res2.get_value('foobar', 'qux') == 1.5
443443

444444
def test_fancy_index_misc(self):
445445
# axis = 0

pandas/tests/core/sparse/test_indexing.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# pylint: disable-msg=E1101,W0612
22

3-
import pytest # noqa
3+
import pytest
44
import numpy as np
55
import pandas as pd
66
import pandas.util.testing as tm
@@ -578,15 +578,15 @@ def test_reindex(self):
578578
exp = orig.reindex(['A'], level=0).to_sparse()
579579
tm.assert_sp_series_equal(res, exp)
580580

581-
with tm.assertRaises(TypeError):
581+
with pytest.raises(TypeError):
582582
# Incomplete keys are not accepted for reindexing:
583583
sparse.reindex(['A', 'C'])
584584

585585
# "copy" argument:
586586
res = sparse.reindex(sparse.index, copy=True)
587587
exp = orig.reindex(orig.index, copy=True).to_sparse()
588588
tm.assert_sp_series_equal(res, exp)
589-
self.assertIsNot(sparse, res)
589+
assert sparse is not res
590590

591591

592592
class TestSparseDataFrameIndexing(tm.TestCase):

pandas/tests/core/sparse/test_series.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -314,9 +314,9 @@ def test_constructor_empty(self):
314314

315315
def test_copy_astype(self):
316316
cop = self.bseries.astype(np.float64)
317-
self.assertIsNot(cop, self.bseries)
318-
self.assertIs(cop.sp_index, self.bseries.sp_index)
319-
self.assertEqual(cop.dtype, np.float64)
317+
assert cop is not self.bseries
318+
assert cop.sp_index is self.bseries.sp_index
319+
assert cop.dtype == np.float64
320320

321321
cop2 = self.iseries.copy()
322322

@@ -325,8 +325,8 @@ def test_copy_astype(self):
325325

326326
# test that data is copied
327327
cop[:5] = 97
328-
self.assertEqual(cop.sp_values[0], 97)
329-
self.assertNotEqual(self.bseries.sp_values[0], 97)
328+
assert cop.sp_values[0] == 97
329+
assert self.bseries.sp_values[0] != 97
330330

331331
# correct fill value
332332
zbcop = self.zbseries.copy()
@@ -338,7 +338,7 @@ def test_copy_astype(self):
338338
# no deep copy
339339
view = self.bseries.copy(deep=False)
340340
view.sp_values[:5] = 5
341-
self.assertTrue((self.bseries.sp_values[:5] == 5).all())
341+
assert (self.bseries.sp_values[:5] == 5).all()
342342

343343
def test_shape(self):
344344
# GH 10452
@@ -639,7 +639,7 @@ def _compare_with_series(sps, new_index):
639639
# special cases
640640
same_index = self.bseries.reindex(self.bseries.index)
641641
tm.assert_sp_series_equal(self.bseries, same_index)
642-
self.assertIsNot(same_index, self.bseries)
642+
assert same_index is not self.bseries
643643

644644
# corner cases
645645
sp = SparseSeries([], index=[])
@@ -650,7 +650,7 @@ def _compare_with_series(sps, new_index):
650650
# with copy=False
651651
reindexed = self.bseries.reindex(self.bseries.index, copy=True)
652652
reindexed.sp_values[:] = 1.
653-
self.assertTrue((self.bseries.sp_values != 1.).all())
653+
assert (self.bseries.sp_values != 1.).all()
654654

655655
reindexed = self.bseries.reindex(self.bseries.index, copy=False)
656656
reindexed.sp_values[:] = 1.
@@ -824,7 +824,7 @@ def test_shift(self):
824824
series = SparseSeries([nan, 1., 2., 3., nan, nan], index=np.arange(6))
825825

826826
shifted = series.shift(0)
827-
self.assertIsNot(shifted, series)
827+
assert shifted is not series
828828
tm.assert_sp_series_equal(shifted, series)
829829

830830
f = lambda s: s.shift(1)

pandas/tests/frame/test_axis_select_reindex.py

+30-26
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
from __future__ import print_function
44

5+
import pytest
6+
57
from datetime import datetime
68

79
from numpy import random
@@ -409,33 +411,35 @@ def test_reindex_dups(self):
409411

410412
def test_align(self):
411413
af, bf = self.frame.align(self.frame)
412-
self.assertIsNot(af._data, self.frame._data)
414+
assert af._data is not self.frame._data
413415

414416
af, bf = self.frame.align(self.frame, copy=False)
415-
self.assertIs(af._data, self.frame._data)
417+
assert af._data is self.frame._data
416418

417419
# axis = 0
418420
other = self.frame.iloc[:-5, :3]
419421
af, bf = self.frame.align(other, axis=0, fill_value=-1)
420-
self.assert_index_equal(bf.columns, other.columns)
422+
423+
tm.assert_index_equal(bf.columns, other.columns)
424+
421425
# test fill value
422426
join_idx = self.frame.index.join(other.index)
423427
diff_a = self.frame.index.difference(join_idx)
424428
diff_b = other.index.difference(join_idx)
425429
diff_a_vals = af.reindex(diff_a).values
426430
diff_b_vals = bf.reindex(diff_b).values
427-
self.assertTrue((diff_a_vals == -1).all())
431+
assert (diff_a_vals == -1).all()
428432

429433
af, bf = self.frame.align(other, join='right', axis=0)
430-
self.assert_index_equal(bf.columns, other.columns)
431-
self.assert_index_equal(bf.index, other.index)
432-
self.assert_index_equal(af.index, other.index)
434+
tm.assert_index_equal(bf.columns, other.columns)
435+
tm.assert_index_equal(bf.index, other.index)
436+
tm.assert_index_equal(af.index, other.index)
433437

434438
# axis = 1
435439
other = self.frame.iloc[:-5, :3].copy()
436440
af, bf = self.frame.align(other, axis=1)
437-
self.assert_index_equal(bf.columns, self.frame.columns)
438-
self.assert_index_equal(bf.index, other.index)
441+
tm.assert_index_equal(bf.columns, self.frame.columns)
442+
tm.assert_index_equal(bf.index, other.index)
439443

440444
# test fill value
441445
join_idx = self.frame.index.join(other.index)
@@ -446,42 +450,42 @@ def test_align(self):
446450
# TODO(wesm): unused?
447451
diff_b_vals = bf.reindex(diff_b).values # noqa
448452

449-
self.assertTrue((diff_a_vals == -1).all())
453+
assert (diff_a_vals == -1).all()
450454

451455
af, bf = self.frame.align(other, join='inner', axis=1)
452-
self.assert_index_equal(bf.columns, other.columns)
456+
tm.assert_index_equal(bf.columns, other.columns)
453457

454458
af, bf = self.frame.align(other, join='inner', axis=1, method='pad')
455-
self.assert_index_equal(bf.columns, other.columns)
459+
tm.assert_index_equal(bf.columns, other.columns)
456460

457461
# test other non-float types
458462
af, bf = self.intframe.align(other, join='inner', axis=1, method='pad')
459-
self.assert_index_equal(bf.columns, other.columns)
463+
tm.assert_index_equal(bf.columns, other.columns)
460464

461465
af, bf = self.mixed_frame.align(self.mixed_frame,
462466
join='inner', axis=1, method='pad')
463-
self.assert_index_equal(bf.columns, self.mixed_frame.columns)
467+
tm.assert_index_equal(bf.columns, self.mixed_frame.columns)
464468

465469
af, bf = self.frame.align(other.iloc[:, 0], join='inner', axis=1,
466470
method=None, fill_value=None)
467-
self.assert_index_equal(bf.index, Index([]))
471+
tm.assert_index_equal(bf.index, Index([]))
468472

469473
af, bf = self.frame.align(other.iloc[:, 0], join='inner', axis=1,
470474
method=None, fill_value=0)
471-
self.assert_index_equal(bf.index, Index([]))
475+
tm.assert_index_equal(bf.index, Index([]))
472476

473477
# mixed floats/ints
474478
af, bf = self.mixed_float.align(other.iloc[:, 0], join='inner', axis=1,
475479
method=None, fill_value=0)
476-
self.assert_index_equal(bf.index, Index([]))
480+
tm.assert_index_equal(bf.index, Index([]))
477481

478482
af, bf = self.mixed_int.align(other.iloc[:, 0], join='inner', axis=1,
479483
method=None, fill_value=0)
480-
self.assert_index_equal(bf.index, Index([]))
484+
tm.assert_index_equal(bf.index, Index([]))
481485

482-
# try to align dataframe to series along bad axis
483-
self.assertRaises(ValueError, self.frame.align, af.iloc[0, :3],
484-
join='inner', axis=2)
486+
# Try to align DataFrame to Series along bad axis
487+
with pytest.raises(ValueError):
488+
self.frame.align(af.iloc[0, :3], join='inner', axis=2)
485489

486490
# align dataframe to series with broadcast or not
487491
idx = self.frame.index
@@ -490,7 +494,7 @@ def test_align(self):
490494
left, right = self.frame.align(s, axis=0)
491495
tm.assert_index_equal(left.index, self.frame.index)
492496
tm.assert_index_equal(right.index, self.frame.index)
493-
self.assertTrue(isinstance(right, Series))
497+
assert isinstance(right, Series)
494498

495499
left, right = self.frame.align(s, broadcast_axis=1)
496500
tm.assert_index_equal(left.index, self.frame.index)
@@ -499,17 +503,17 @@ def test_align(self):
499503
expected[c] = s
500504
expected = DataFrame(expected, index=self.frame.index,
501505
columns=self.frame.columns)
502-
assert_frame_equal(right, expected)
506+
tm.assert_frame_equal(right, expected)
503507

504-
# GH 9558
508+
# see gh-9558
505509
df = DataFrame({'a': [1, 2, 3], 'b': [4, 5, 6]})
506510
result = df[df['a'] == 2]
507511
expected = DataFrame([[2, 5]], index=[1], columns=['a', 'b'])
508-
assert_frame_equal(result, expected)
512+
tm.assert_frame_equal(result, expected)
509513

510514
result = df.where(df['a'] == 2, 0)
511515
expected = DataFrame({'a': [0, 2, 0], 'b': [0, 5, 0]})
512-
assert_frame_equal(result, expected)
516+
tm.assert_frame_equal(result, expected)
513517

514518
def _check_align(self, a, b, axis, fill_axis, how, method, limit=None):
515519
aa, ab = a.align(b, axis=axis, join=how, method=method, limit=limit,

pandas/tests/frame/test_block_internals.py

+8-7
Original file line numberDiff line numberDiff line change
@@ -41,17 +41,18 @@ def test_cast_internals(self):
4141
def test_consolidate(self):
4242
self.frame['E'] = 7.
4343
consolidated = self.frame._consolidate()
44-
self.assertEqual(len(consolidated._data.blocks), 1)
44+
assert len(consolidated._data.blocks) == 1
4545

4646
# Ensure copy, do I want this?
4747
recons = consolidated._consolidate()
48-
self.assertIsNot(recons, consolidated)
49-
assert_frame_equal(recons, consolidated)
48+
assert recons is not consolidated
49+
tm.assert_frame_equal(recons, consolidated)
5050

5151
self.frame['F'] = 8.
52-
self.assertEqual(len(self.frame._data.blocks), 3)
52+
assert len(self.frame._data.blocks) == 3
53+
5354
self.frame._consolidate(inplace=True)
54-
self.assertEqual(len(self.frame._data.blocks), 1)
55+
assert len(self.frame._data.blocks) == 1
5556

5657
def test_consolidate_deprecation(self):
5758
self.frame['E'] = 7
@@ -343,11 +344,11 @@ def test_no_copy_blocks(self):
343344
def test_copy(self):
344345
cop = self.frame.copy()
345346
cop['E'] = cop['A']
346-
self.assertNotIn('E', self.frame)
347+
assert 'E' not in self.frame
347348

348349
# copy objects
349350
copy = self.mixed_frame.copy()
350-
self.assertIsNot(copy._data, self.mixed_frame._data)
351+
assert copy._data is not self.mixed_frame._data
351352

352353
def test_pickle(self):
353354
unpickled = tm.round_trip_pickle(self.mixed_frame)

pandas/tests/frame/test_indexing.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -672,19 +672,19 @@ def test_setitem_ambig(self):
672672
self.assertEqual(dm[2].dtype, np.object_)
673673

674674
def test_setitem_clear_caches(self):
675-
# GH #304
675+
# see gh-304
676676
df = DataFrame({'x': [1.1, 2.1, 3.1, 4.1], 'y': [5.1, 6.1, 7.1, 8.1]},
677677
index=[0, 1, 2, 3])
678678
df.insert(2, 'z', np.nan)
679679

680680
# cache it
681681
foo = df['z']
682-
683682
df.loc[df.index[2:], 'z'] = 42
684683

685684
expected = Series([np.nan, np.nan, 42, 42], index=df.index, name='z')
686-
self.assertIsNot(df['z'], foo)
687-
assert_series_equal(df['z'], expected)
685+
686+
assert df['z'] is not foo
687+
tm.assert_series_equal(df['z'], expected)
688688

689689
def test_setitem_None(self):
690690
# GH #766

pandas/tests/frame/test_missing.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -403,18 +403,18 @@ def test_fillna_inplace(self):
403403
df[3][-4:] = np.nan
404404

405405
expected = df.fillna(value=0)
406-
self.assertIsNot(expected, df)
406+
assert expected is not df
407407

408408
df.fillna(value=0, inplace=True)
409-
assert_frame_equal(df, expected)
409+
tm.assert_frame_equal(df, expected)
410410

411411
df[1][:4] = np.nan
412412
df[3][-4:] = np.nan
413413
expected = df.fillna(method='ffill')
414-
self.assertIsNot(expected, df)
414+
assert expected is not df
415415

416416
df.fillna(method='ffill', inplace=True)
417-
assert_frame_equal(df, expected)
417+
tm.assert_frame_equal(df, expected)
418418

419419
def test_fillna_dict_series(self):
420420
df = DataFrame({'a': [nan, 1, 2, nan, nan],

pandas/tests/frame/test_timeseries.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
import pandas as pd
1515
import pandas.tseries.offsets as offsets
1616

17-
from pandas.util.testing import (assert_almost_equal,
18-
assert_series_equal,
17+
from pandas.util.testing import (assert_series_equal,
1918
assert_frame_equal,
2019
assertRaisesRegexp)
2120

@@ -355,7 +354,7 @@ def test_asfreq(self):
355354
offset_monthly = self.tsframe.asfreq(offsets.BMonthEnd())
356355
rule_monthly = self.tsframe.asfreq('BM')
357356

358-
assert_almost_equal(offset_monthly['A'], rule_monthly['A'])
357+
tm.assert_almost_equal(offset_monthly['A'], rule_monthly['A'])
359358

360359
filled = rule_monthly.asfreq('B', method='pad') # noqa
361360
# TODO: actually check that this worked.
@@ -366,7 +365,7 @@ def test_asfreq(self):
366365
# test does not blow up on length-0 DataFrame
367366
zero_length = self.tsframe.reindex([])
368367
result = zero_length.asfreq('BM')
369-
self.assertIsNot(result, zero_length)
368+
assert result is not zero_length
370369

371370
def test_asfreq_datetimeindex(self):
372371
df = DataFrame({'A': [1, 2, 3]},

0 commit comments

Comments
 (0)