Skip to content

BUG: show series length in repr when truncated (GH15962) #15974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2017
Merged

BUG: show series length in repr when truncated (GH15962) #15974

merged 3 commits into from
Apr 18, 2017

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Apr 11, 2017 •
edited
Loading

Also follow the display.show_dimensions option.

@jorisvandenbossche jorisvandenbossche mentioned this pull request Apr 11, 2017
Closed
@jorisvandenbossche jorisvandenbossche added the Output-Formatting __repr__ of pandas objects, to_string label Apr 11, 2017
jreback
jreback reviewed Apr 11, 2017
View reviewed changes
pandas/formats/format.py Outdated
@@ -197,7 +197,8 @@ def _get_footer(self):
escape_chars=('\t', '\r', '\n'))
footer += ("Name: %s" % series_name) if name is not None else ""

if self.length:
if (self.length is True or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have a check on the valid values of this (even though the option actually vets this)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I actually misuse the length keyword here a bit, which is normally a True/False keyword, but by internally also passing 'truncate' to it (otherwise I had to create a new keyword show_dimensions, which would render length useless)

jreback
jreback reviewed Apr 11, 2017
View reviewed changes
pandas/tests/formats/test_format.py Outdated
@@ -2084,6 +2089,21 @@ def getndots(s):
strrepr = repr(s).replace('\n', '')
self.assertEqual(getndots(strrepr), 3)

def test_show_dimensions(self):
s = Series(range(5))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the issue number here

@jreback
Copy link
Contributor

jreback commented Apr 11, 2017

lgtm.

@jreback jreback added this to the 0.20.0 milestone Apr 13, 2017
@jreback
Copy link
Contributor

jreback commented Apr 13, 2017

@jorisvandenbossche can you update

@codecov
Copy link

codecov bot commented Apr 18, 2017

Codecov Report

Merging #15974 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15974      +/-   ##
==========================================
+ Coverage   90.99%      91%   +<.01%     
==========================================
  Files         153      153              
  Lines       50481    50478       -3     
==========================================
- Hits        45937    45935       -2     
+ Misses       4544     4543       -1
Flag Coverage Δ
#multiple 88.76% <66.66%> (ø) ⬆️
#single 40.43% <55.55%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/format.py 95.11% <100%> (ø) ⬆️
pandas/core/series.py 95.07% <62.5%> (-0.02%) ⬇️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/util/testing.py 80.73% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1031f...daf01f7. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 18, 2017 •
edited
Loading

Codecov Report

Merging #15974 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15974      +/-   ##
==========================================
+ Coverage   90.99%      91%   +<.01%     
==========================================
  Files         153      153              
  Lines       50481    50478       -3     
==========================================
- Hits        45937    45935       -2     
+ Misses       4544     4543       -1
Flag Coverage Δ
#multiple 88.76% <66.66%> (ø) ⬆️
#single 40.43% <55.55%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/format.py 95.11% <100%> (ø) ⬆️
pandas/core/series.py 95.07% <62.5%> (-0.02%) ⬇️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/util/testing.py 80.73% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1031f...daf01f7. Read the comment docs.

@jorisvandenbossche jorisvandenbossche merged commit f53d38b into pandas-dev:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

Option for showing length of series API: use show_dimensions default to decide whether to show Series length
2 participants
@jorisvandenbossche @jreback