API: use show_dimensions default to decide whether to show Series length

[jreback]

rather than display.max_rows directly

for considency with the new 'truncate' option

[jreback]

cc @bjonen if you have time

[bjonen]

So you are referring to changing this line?
https://github.com/pydata/pandas/blob/master/pandas/core/series.py#L831
Right now, the dimensions are only printed if we produce a tidy_repr.

And you would like the docs to be implemented?

Whether to print out dimensions at the end of DataFrame repr.
If 'truncate' is specified, only print out the dimensions if the
frame is truncated (e.g. not display all rows and/or columns)

[jreback]

would be reworking this to decide if it's truncated
then based on show_dimensions setting shoe the length ( or not)

[bjonen]

show_dimennsions can be

• truncate: In this case we print the dimensions only if the series gets truncated.
• True In this case we print the dimensions (this is not implemented right now) independent of whether the series got truncated.
• False In this case we do not print the dimensions inpependent of whether the series got truncated.

If that's ok I can make the adjustment.

[jreback]

that looks right (tests are current in test_format.py for the DataFrame impl of this, so maybe add Series to that or below). Further can you update the show_dimensions option in core/config_init.py to reflect this better?

thanks

[jorisvandenbossche]

Am I right that nothing will change with the default settings? (as in 0.14 the length of the series is only shown when truncated, and the show_dimensions option is 'truncate' by default)
So only if a user would set show_dimensions to True or False the display behaviour will change (and always or never show the series length)?

Just asking because I was doubting if this would warrant a change in the default display behaviour (but AFAIU, this is not the case so no problem).

[jorisvandenbossche]

BTW, while testing I saw another issue: #7508

[jreback]

@jorisvandenbossche the user facing API shouldn't change (as the default is basically 'truncate' with Series now). but will be consistent if the user DOES change it.