CLN: Remove "flake8: noqa" from more files #15867
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15867 +/- ##
==========================================
- Coverage 90.98% 90.97% -0.02%
==========================================
Files 143 143
Lines 49449 49449
==========================================
- Hits 44993 44984 -9
- Misses 4456 4465 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #15867 +/- ##
==========================================
- Coverage 90.98% 90.97% -0.02%
==========================================
Files 143 143
Lines 49449 49449
==========================================
- Hits 44992 44984 -8
- Misses 4457 4465 +8
Continue to review full report at Codecov.
|
pandas/tseries/common.py
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import numpy as np | |||
|
|
|||
| from pandas.types.common import (_NS_DTYPE, _TD_DTYPE, | |||
| from pandas.types.common import (_NS_DTYPE, _TD_DTYPE, # noqa | |||
There was a problem hiding this comment.
actually I think you can just take these out (you may need to import them where they are actually used though)
There was a problem hiding this comment.
Fair enough. Will remove then.
gfyoung
force-pushed
the
flake8-noqa-clean
branch
from
632de71 to
0c84926
Compare
| @@ -589,10 +588,10 @@ def test_string_categorical_index_repr(self): | |||
| # short | |||
| idx = pd.CategoricalIndex(['a', 'bb', 'ccc']) | |||
| if PY3: | |||
| expected = u"""CategoricalIndex(['a', 'bb', 'ccc'], categories=['a', 'bb', 'ccc'], ordered=False, dtype='category')""" | |||
| expected = u"""CategoricalIndex(['a', 'bb', 'ccc'], categories=['a', 'bb', 'ccc'], ordered=False, dtype='category')""" # noqa | |||
There was a problem hiding this comment.
thanks @gfyoung yeah we DO want to fix the actual repr at some point (more involved)!
Another round of house-cleaning that builds off #15867. Likely to be the last one for now. Author: gfyoung <[email protected]> Closes #15872 from gfyoung/flake8-noqa-clean and squashes the following commits: 3e610f5 [gfyoung] CLN: Make pickle_compat.py flake8-able 05e067a [gfyoung] CLN: Make windows.py flake8-able dc22c0a [gfyoung] CLN: Make clipboards.py flake8-able 90b00f0 [gfyoung] CLN: Make clipboard/__init__.py flake8-able ccb44cc [gfyoung] CLN: Make engines.py flake8-able
Another round of house-cleaning that builds off #15842.
xref #12066 (comment) : the issue remains unresolved, but it does not seem entirely necessary to disable style-checking on the entire file for that IMO.