CLN: Remove "flake8: noqa" from files #15842
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
changed the title
Codecov Report
@@ Coverage Diff @@
## master #15842 +/- ##
==========================================
- Coverage 90.97% 90.96% -0.02%
==========================================
Files 143 143
Lines 49442 49442
==========================================
- Hits 44982 44973 -9
- Misses 4460 4469 +9
Continue to review full report at Codecov.
|
|
thanks! |
jreback
pushed a commit
that referenced
this pull request
Apr 2, 2017
Another round of house-cleaning that builds off #15842. xref <a href="https://github.com/pandas- dev/pandas/issues/12066#issuecomment-172285473">#12066 (comment)</a> : the issue remains unresolved, but it does not seem entirely necessary to disable style-checking on the entire file for that IMO. Author: gfyoung <[email protected]> Closes #15867 from gfyoung/flake8-noqa-clean and squashes the following commits: 0c84926 [gfyoung] CLN: Make tseries/common.py flake8-able 7a799ff [gfyoung] CLN: Make _version.py flake8-able 7087b64 [gfyoung] CLN: Make test_categorical.py flake8-able 5d5abf8 [gfyoung] CLN: Make test_categorical.py flake8-able 6ace90b [gfyoung] CLN: Make test_eval.py flake8-able
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
Just some minor house-cleaning to cut down on the number of search results found <a href="https://github.com/pandas- dev/pandas/search?utf8=%E2%9C%93&q=flake8%3A+noqa&type=">here</a>. Author: gfyoung <[email protected]> Closes pandas-dev#15842 from gfyoung/flake8-noqa-clean and squashes the following commits: 5d1edeb [gfyoung] CLN: Make test_compat.py flake8-able f9079ff [gfyoung] CLN: Make exceptions.py flake8-able 0e236f5 [gfyoung] CLN: Make test_format.py flake8-able
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor house-cleaning to cut down on the number of search results found here.