Skip to content

CLN/INT: Rename _possibly to _maybe (GH15764) #15771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

CLN/INT: Rename _possibly to _maybe (GH15764) #15771

wants to merge 2 commits into from

Conversation

StanczakDominik
Copy link
Contributor

@StanczakDominik StanczakDominik commented Mar 21, 2017 •
edited
Loading

Also rename "private" functions in pandas.type.cast

@StanczakDominik
CLN/INT: Rename _possibly to _maybe
188c48b 
Also rename "private" functions in pandas.type.cast

Closes pandas-dev#15764
@jreback
Copy link
Contributor

jreback commented Mar 21, 2017

thanks @StanczakDominik exactly what I was looking.

ping on green. (hopefully linting passes too!).

@jreback jreback added the Clean label Mar 21, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 21, 2017
@jreback
Copy link
Contributor

jreback commented Mar 21, 2017

couple of linting errors.

pandas/computation/expr.py:386:56: E127 continuation line over-indented for visual indent
pandas/core/internals.py:5144:80: E501 line too long (88 > 79 characters)

@codecov
Copy link

codecov bot commented Mar 22, 2017 •
edited
Loading

Codecov Report

Merging #15771 into master will decrease coverage by 0.01%.
The diff coverage is 97.01%.

@@            Coverage Diff             @@
##           master   #15771      +/-   ##
==========================================
- Coverage   91.01%      91%   -0.02%     
==========================================
  Files         143      143              
  Lines       49377    49403      +26     
==========================================
+ Hits        44941    44958      +17     
- Misses       4436     4445       +9
Impacted Files Coverage Δ
pandas/tools/util.py 96.84% <100%> (ø) ⬆️
pandas/io/parsers.py 95.51% <100%> (ø) ⬆️
pandas/core/categorical.py 96.89% <100%> (ø) ⬆️
pandas/core/frame.py 97.86% <100%> (-0.1%) ⬇️
pandas/core/generic.py 96.24% <100%> (ø) ⬆️
pandas/core/groupby.py 94.96% <100%> (ø) ⬆️
pandas/core/reshape.py 99.27% <100%> (ø) ⬆️
pandas/tseries/tdi.py 90.23% <100%> (ø) ⬆️
pandas/core/panel.py 97.78% <100%> (ø) ⬆️
pandas/sparse/array.py 91.46% <100%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 163d18e...486b932. Read the comment docs.

StanczakDominik
StanczakDominik commented Mar 22, 2017
View reviewed changes
pandas/tests/types/test_cast.py
from pandas.types.dtypes import (CategoricalDtype,
DatetimeTZDtype, PeriodDtype)
from pandas.util import testing as tm


class TestPossiblyDowncast(tm.TestCase):
class TestMaybeDowncast(tm.TestCase):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't quite sure whether or not I should change the name of this class. It seemed logical as it seemed to refer to the "private" method I had changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that is fine

@StanczakDominik
Copy link
Contributor Author

Well, I guess I must have missed them somehow.

I'm not entirely sure why Codecov claims this would decrease coverage. It might be related to my comment above.

By the way, as this is my first foray into giving back to the awesome packages in the Python ecosystem, I'm not entirely sure if my thinking is correct: once test pass, I should squish my commits into one for inclusion in master, right?

@jreback
Copy link
Contributor

jreback commented Mar 22, 2017

no worries @StanczakDominik for future reference: http://pandas-docs.github.io/pandas-docs-travis/contributing.html#python-pep8

@jreback jreback closed this in 2a3b05a Mar 22, 2017
@jreback
Copy link
Contributor

jreback commented Mar 22, 2017

thanks @StanczakDominik

@StanczakDominik StanczakDominik deleted the rename-possibly branch March 22, 2017 12:24
mattip pushed a commit to mattip/pandas that referenced this pull request Apr 3, 2017
@StanczakDominik @mattip
CLN/INT: Rename _possibly to _maybe (GH15764)
7e94fe9 
Also rename "private" functions in pandas.type.cast
closes pandas-dev#15764

Author: Dominik Stanczak <[email protected]>

Closes pandas-dev#15771 from StanczakDominik/rename-possibly and squashes the following commits:

486b932 [Dominik Stanczak] Cleanup missed linting errors
188c48b [Dominik Stanczak] CLN/INT: Rename _possibly to _maybe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

CLN/INT: rename *possibly* -> *maybe* functions
2 participants
@StanczakDominik @jreback